Date: Wed, 13 Jan 2016 20:54:55 +0800 From: Sepherosa Ziehau <sephe@freebsd.org> To: "Bjoern A. Zeeb" <bz@freebsd.org>, Xin LI <delphij@freebsd.org>, Adrian Chadd <adrian@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293719 - head/sys/dev/hyperv/netvsc Message-ID: <CAMOc5czJ6s1=BNP5GLE3-bYgijk-JfeixBhk1q1S29LD6fbLCg@mail.gmail.com> In-Reply-To: <alpine.BSF.2.00.1601131047330.92377@ai.fobar.qr> References: <201601120130.u0C1UpvA074721@repo.freebsd.org> <alpine.BSF.2.00.1601131047330.92377@ai.fobar.qr>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a113f8f3a4cd065052936ade4 Content-Type: text/plain; charset=UTF-8 The breakage is all my fault. Patch is attached. Wait for mentors approval. Thanks, sephe On Wed, Jan 13, 2016 at 6:49 PM, Bjoern A. Zeeb <bz@freebsd.org> wrote: > On Tue, 12 Jan 2016, Sepherosa Ziehau wrote: > >> Author: sephe >> Date: Tue Jan 12 01:30:51 2016 >> New Revision: 293719 >> URL: https://svnweb.freebsd.org/changeset/base/293719 >> >> Log: >> hyperv/hn: Implement LRO >> >> - Implement the LRO using tcp_lro APIs, and LRO is enabled by default. > > > Which are only available if INET or INET6 are compiled into the kernel. > Unfortunately this breaks kernel builds that do not include IPv4 or IPv6 > support. > > Can you please put appropriate #if defined(INET6) || defined(INET) in > place? > > > >> Differential Revision: https://reviews.freebsd.org/D4824 >> >> Modified: >> head/sys/dev/hyperv/netvsc/hv_net_vsc.c >> head/sys/dev/hyperv/netvsc/hv_net_vsc.h >> head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c > > > hv_netvsc_drv_freebsd.o: In function `netvsc_recv': > /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x483): > undefined reference to `tcp_lro_rx' > hv_netvsc_drv_freebsd.o: In function `netvsc_recv_rollup': > /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x5ce): > undefined reference to `tcp_lro_flush' > hv_netvsc_drv_freebsd.o: In function `netvsc_attach': > /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x901): > undefined reference to `tcp_lro_init' > hv_netvsc_drv_freebsd.o: In function `netvsc_detach': > /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0xca8): > undefined reference to `tcp_lro_free' > --- kernel --- > *** [kernel] Error code 1 > bmake: stopped in /storage/head/obj/scratch/tmp/bz/head.svn/sys/LINT-NOIP > > >> head/sys/dev/hyperv/netvsc/hv_rndis.h >> head/sys/dev/hyperv/netvsc/hv_rndis_filter.c >> head/sys/dev/hyperv/netvsc/hv_rndis_filter.h -- Tomorrow Will Never Die --001a113f8f3a4cd065052936ade4 Content-Type: text/plain; charset=US-ASCII; name="hn_unbreak_lint_noip.diff" Content-Disposition: attachment; filename="hn_unbreak_lint_noip.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ijctx3sj0 ZGlmZiAtLWdpdCBhL3N5cy9kZXYvaHlwZXJ2L25ldHZzYy9odl9uZXR2c2NfZHJ2X2ZyZWVic2Qu YyBiL3N5cy9kZXYvaHlwZXJ2L25ldHZzYy9odl9uZXR2c2NfZHJ2X2ZyZWVic2QuYwppbmRleCA2 OGY4MjJhLi5mZDIzZGI5IDEwMDY0NAotLS0gYS9zeXMvZGV2L2h5cGVydi9uZXR2c2MvaHZfbmV0 dnNjX2Rydl9mcmVlYnNkLmMKKysrIGIvc3lzL2Rldi9oeXBlcnYvbmV0dnNjL2h2X25ldHZzY19k cnZfZnJlZWJzZC5jCkBAIC0zOTEsMTIgKzM5MSwxNCBAQCBuZXR2c2NfYXR0YWNoKGRldmljZV90 IGRldikKIAkJc2MtPmhuX2NhcnJpZXIgPSAxOwogCX0KIAorI2lmIGRlZmluZWQoSU5FVCkgfHwg ZGVmaW5lZChJTkVUNikKIAl0Y3BfbHJvX2luaXQoJnNjLT5obl9scm8pOwogCS8qIERyaXZlciBw cml2YXRlIExSTyBzZXR0aW5ncyAqLwogCXNjLT5obl9scm8uaWZwID0gaWZwOwogI2lmZGVmIEhO X0xST19ISVdBVAogCXNjLT5obl9scm8ubHJvX2hpd2F0ID0gc2MtPmhuX2xyb19oaXdhdDsKICNl bmRpZgorI2VuZGlmCS8qIElORVQgfHwgSU5FVDYgKi8KIAogCWV0aGVyX2lmYXR0YWNoKGlmcCwg ZGV2aWNlX2luZm8ubWFjX2FkZHIpOwogCkBAIC00NzUsNyArNDc3LDkgQEAgbmV0dnNjX2RldGFj aChkZXZpY2VfdCBkZXYpCiAJaHZfcmZfb25fZGV2aWNlX3JlbW92ZShodl9kZXZpY2UsIEhWX1JG X05WX0RFU1RST1lfQ0hBTk5FTCk7CiAKIAlpZm1lZGlhX3JlbW92ZWFsbCgmc2MtPmhuX21lZGlh KTsKKyNpZiBkZWZpbmVkKElORVQpIHx8IGRlZmluZWQoSU5FVDYpCiAJdGNwX2xyb19mcmVlKCZz Yy0+aG5fbHJvKTsKKyNlbmRpZgogCiAJcmV0dXJuICgwKTsKIH0KQEAgLTEwODMsNiArMTA4Nyw3 IEBAIHNraXA6CiAJaWZfaW5jX2NvdW50ZXIoaWZwLCBJRkNPVU5URVJfSVBBQ0tFVFMsIDEpOwog CiAJaWYgKChpZnAtPmlmX2NhcGVuYWJsZSAmIElGQ0FQX0xSTykgJiYgZG9fbHJvKSB7CisjaWYg ZGVmaW5lZChJTkVUKSB8fCBkZWZpbmVkKElORVQ2KQogCQlzdHJ1Y3QgbHJvX2N0cmwgKmxybyA9 ICZzYy0+aG5fbHJvOwogCiAJCWlmIChscm8tPmxyb19jbnQpIHsKQEAgLTEwOTIsNiArMTA5Nyw3 IEBAIHNraXA6CiAJCQkJcmV0dXJuIDA7CiAJCQl9CiAJCX0KKyNlbmRpZgogCX0KIAogCS8qIFdl J3JlIG5vdCBob2xkaW5nIHRoZSBsb2NrIGhlcmUsIHNvIGRvbid0IHJlbGVhc2UgaXQgKi8KQEAg LTExMDMsNiArMTEwOSw3IEBAIHNraXA6CiB2b2lkCiBuZXR2c2NfcmVjdl9yb2xsdXAoc3RydWN0 IGh2X2RldmljZSAqZGV2aWNlX2N0eCkKIHsKKyNpZiBkZWZpbmVkKElORVQpIHx8IGRlZmluZWQo SU5FVDYpCiAJaG5fc29mdGNfdCAqc2MgPSBkZXZpY2VfZ2V0X3NvZnRjKGRldmljZV9jdHgtPmRl dmljZSk7CiAJc3RydWN0IGxyb19jdHJsICpscm8gPSAmc2MtPmhuX2xybzsKIAlzdHJ1Y3QgbHJv X2VudHJ5ICpxdWV1ZWQ7CkBAIC0xMTExLDYgKzExMTgsNyBAQCBuZXR2c2NfcmVjdl9yb2xsdXAo c3RydWN0IGh2X2RldmljZSAqZGV2aWNlX2N0eCkKIAkJU0xJU1RfUkVNT1ZFX0hFQUQoJmxyby0+ bHJvX2FjdGl2ZSwgbmV4dCk7CiAJCXRjcF9scm9fZmx1c2gobHJvLCBxdWV1ZWQpOwogCX0KKyNl bmRpZgogfQogCiAvKgo= --001a113f8f3a4cd065052936ade4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMOc5czJ6s1=BNP5GLE3-bYgijk-JfeixBhk1q1S29LD6fbLCg>