Date: Sat, 11 Apr 2009 20:25:09 +0200 From: Erwin Lansing <erwin@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: Rui Paulo <rpaulo@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo <rpaulo@FreeBSD.org> Subject: Re: svn commit: r190944 - in head/contrib/libpcap: . bpf/net pcap Message-ID: <20090411182508.GL78186@droso.net> In-Reply-To: <20090411214746.92c585da.stas@FreeBSD.org> References: <200904111736.n3BHaBP7093616@svn.freebsd.org> <1281775D-CD42-4430-9ED0-8472F10826EA@gmail.com> <20090411214746.92c585da.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ZqYDZSN9O5ZeiDmL Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 11, 2009 at 09:47:46PM +0400, Stanislav Sedov wrote: > On Sat, 11 Apr 2009 18:37:28 +0100 > Rui Paulo <rpaulo@gmail.com> mentioned: >=20 > >=20 > > On 11 Apr 2009, at 18:36, Rui Paulo wrote: > >=20 > > > Author: rpaulo > > > Date: Sat Apr 11 17:36:11 2009 > > > New Revision: 190944 > > > URL: http://svn.freebsd.org/changeset/base/190944 > > > > > > Log: > > > Revert previous commit that commented out some bpf functions. > > > Unconstify arguments of bpf_image(), bpf_filter() and bpf_dump(). = =20 > > > This > > > is needed because some ports rely heavely on these arguments (some of > > > them even roll out their own implemenentations of bpf_dump). > >=20 > > We can revisit this issue in the future if ports start complying with = =20 > > new libpcap headers. > >=20 >=20 > Have you analyzed how much ports depend on this? We can fix them locally > if the number is not that high. We have already done that with usb and ot= her > changes. >=20 http://wiki.freebsd.org/PortsBrokenOnCurrent near the bottom. About 8 ports, so definately fixable. How do other OSes handle this? it would certainly be a good thing to be consistent with them for portability and easier upstream integreation. Cheers, -erwin --=20 Erwin Lansing http://droso.org Prediction is very difficult erwin@FreeBSD.org especially about the future erwin@aauug.dk --ZqYDZSN9O5ZeiDmL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFJ4OCEqy9aWxUlaZARAuGhAJ9WM3zbdnR4/EbZRnKXXMglDvdmrgCfShKX jlGTYprj+JLtE/MF0bMqlpk= =ypfT -----END PGP SIGNATURE----- --ZqYDZSN9O5ZeiDmL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090411182508.GL78186>