Date: Thu, 28 Apr 2016 21:17:23 +0000 (UTC) From: Garrett Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r298758 - head/sbin/camcontrol Message-ID: <201604282117.u3SLHNAw085061@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Thu Apr 28 21:17:23 2016 New Revision: 298758 URL: https://svnweb.freebsd.org/changeset/base/298758 Log: Remove logically impossible test in scsidoinquiry(..) It was already done 4 lines prior and the value of error didn't change MFC after: 3 days Reported by: Coverity CID: 1011236 Sponsored by: EMC / Isilon Storage Division Modified: head/sbin/camcontrol/camcontrol.c Modified: head/sbin/camcontrol/camcontrol.c ============================================================================== --- head/sbin/camcontrol/camcontrol.c Thu Apr 28 20:30:49 2016 (r298757) +++ head/sbin/camcontrol/camcontrol.c Thu Apr 28 21:17:23 2016 (r298758) @@ -814,9 +814,6 @@ scsidoinquiry(struct cam_device *device, if (arglist & CAM_ARG_GET_SERIAL) scsiserial(device, retry_count, timeout); - if (error != 0) - return(error); - if (arglist & CAM_ARG_GET_XFERRATE) error = camxferrate(device);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604282117.u3SLHNAw085061>