Date: Sun, 22 Sep 2024 19:19:16 +0100 From: Warner Losh <imp@bsdimp.com> To: Mark Millard <marklmi@yahoo.com> Cc: "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, a.munoz3327@gmail.com Subject: Re: git: 85918beb387f - main - intrng: Add support for multiple interrupt roots Message-ID: <CANCZdfr2CbqBiAfkrHYz%2B837KXAp=aQsRPXt4imqz8_C_DO2gg@mail.gmail.com> In-Reply-To: <1B971CC2-DD1F-488B-A80B-98EF29256D50@yahoo.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Sep 22, 2024, 7:01 PM Mark Millard <marklmi@yahoo.com> wrote: > From: Warner Losh <imp_at_FreeBSD.org> wrote on > Date: Sun, 22 Sep 2024 13:19:21 UTC : > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=85918beb387f179abc93a6c613801fb9761ff1e2 > > > > commit 85918beb387f179abc93a6c613801fb9761ff1e2 > > Author: Ayrton Munoz <a.munoz3327@gmail.com> > > AuthorDate: 2024-07-21 18:10:20 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2024-09-22 13:18:34 +0000 > > > > intrng: Add support for multiple interrupt roots > > > > Different types of interrupts may require using different exception > > vectors so this commit adds support multiple interrupt roots to handle > > these cases. Archs may opt-in to multiple interrupt roots by defining > > INTR_ROOT_NUM as the number of roots in their intr.h. Based off > > https://reviews.freebsd.org/D40161. > > > > Signed-off-by: Ayrton Munoz <a.munoz3327@gmail.com> > > Co-authored-by: Kyle Evans <kevans@FreeBSD.org> > > Co-authored-by: Andrew Turner <andrew@FreeBSD.org> > > Reviewed-by: imp,mmel,mhorne > > Pull-Request: https://github.com/freebsd/freebsd-src/pull/1363 > . . . > > +/* > > + * Archs may define multiple roots with INTR_ROOT_NUM to support > different kinds > > + * of interrupts (e.g. arm64 FIQs which use a different exception > vector than > > + * IRQs). > > + */ > > +#if !defined(INTR_ROOT_NUM) > > +#define INTR_ROOT_NUM 1 > > +#endif > > + > > . . . > > When I was reading the: > > https://github.com/freebsd/freebsd-src/pull/1363 > > conversation I saw: > > -#define INTR_ROOT_NUM 2 > +#define INTR_ROOT_COUNT 2 > > and related discussion with 2 thumbs up, including one by ayrtonm. > > A similar point goes for: > > -void *arg, uint32_t rootnum) > +void *arg, uint32_t roottype) > > with another ayrtonm thumbs up at the end. (I've not checked > if there are more distinctions.) > > Such leaves me wondering if what was committed was actually > the final intended code: Is it? > I thought it was... If we need a fllowup, i can do that... Warner === > Mark Millard > marklmi at yahoo.com > > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Sep 22, 2024, 7:01 PM Mark Millard <<a href="mailto:marklmi@yahoo.com">marklmi@yahoo.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Warner Losh <imp_at_FreeBSD.org> wrote on<br> Date: Sun, 22 Sep 2024 13:19:21 UTC :<br> <br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=85918beb387f179abc93a6c613801fb9761ff1e2" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=85918beb387f179abc93a6c613801fb9761ff1e2</a><br>; > <br> > commit 85918beb387f179abc93a6c613801fb9761ff1e2<br> > Author: Ayrton Munoz <<a href="mailto:a.munoz3327@gmail.com" target="_blank" rel="noreferrer">a.munoz3327@gmail.com</a>><br> > AuthorDate: 2024-07-21 18:10:20 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2024-09-22 13:18:34 +0000<br> > <br> > intrng: Add support for multiple interrupt roots<br> > <br> > Different types of interrupts may require using different exception<br> > vectors so this commit adds support multiple interrupt roots to handle<br> > these cases. Archs may opt-in to multiple interrupt roots by defining<br> > INTR_ROOT_NUM as the number of roots in their intr.h. Based off<br> > <a href="https://reviews.freebsd.org/D40161" rel="noreferrer noreferrer" target="_blank">https://reviews.freebsd.org/D40161</a>.<br>; > <br> > Signed-off-by: Ayrton Munoz <<a href="mailto:a.munoz3327@gmail.com" target="_blank" rel="noreferrer">a.munoz3327@gmail.com</a>><br> > Co-authored-by: Kyle Evans <kevans@FreeBSD.org><br> > Co-authored-by: Andrew Turner <andrew@FreeBSD.org><br> > Reviewed-by: imp,mmel,mhorne<br> > Pull-Request: <a href="https://github.com/freebsd/freebsd-src/pull/1363" rel="noreferrer noreferrer" target="_blank">https://github.com/freebsd/freebsd-src/pull/1363</a><br>; . . .<br> > +/*<br> > + * Archs may define multiple roots with INTR_ROOT_NUM to support different kinds<br> > + * of interrupts (e.g. arm64 FIQs which use a different exception vector than<br> > + * IRQs).<br> > + */<br> > +#if !defined(INTR_ROOT_NUM)<br> > +#define INTR_ROOT_NUM 1<br> > +#endif<br> > +<br> <br> . . .<br> <br> When I was reading the:<br> <br> <a href="https://github.com/freebsd/freebsd-src/pull/1363" rel="noreferrer noreferrer" target="_blank">https://github.com/freebsd/freebsd-src/pull/1363</a><br>; <br> conversation I saw:<br> <br> -#define INTR_ROOT_NUM 2<br> +#define INTR_ROOT_COUNT 2<br> <br> and related discussion with 2 thumbs up, including one by ayrtonm.<br> <br> A similar point goes for:<br> <br> -void *arg, uint32_t rootnum)<br> +void *arg, uint32_t roottype)<br> <br> with another ayrtonm thumbs up at the end. (I've not checked<br> if there are more distinctions.)<br> <br> Such leaves me wondering if what was committed was actually<br> the final intended code: Is it?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I thought it was... If we need a fllowup, i can do that...</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> ===<br> Mark Millard<br> marklmi at <a href="http://yahoo.com" rel="noreferrer noreferrer" target="_blank">yahoo.com</a><br> <br> </blockquote></div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr2CbqBiAfkrHYz%2B837KXAp=aQsRPXt4imqz8_C_DO2gg>