Date: Mon, 14 Dec 1998 06:55:46 +0100 (CET) From: List User <listuser@netspace.net.au> To: freebsd-current@FreeBSD.org Message-ID: <199812140555.GAA09116@doorway.home.lan>
next in thread | raw e-mail | index | archive | help
Newsgroups: freebsd.current Path: root From: Julian Elischer <julian@whistle.com> Subject: Re: if_sppp is BROKEN!!! Content-Type: TEXT/PLAIN; charset=US-ASCII Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpdO12550; Mon Dec 14 04:39:41 1998 To: Poul-Henning Kamp <phk> Sender: owner-freebsd-current@FreeBSD.ORG Organization: Private News Host Precedence: bulk Message-ID: <Pine.BSF.3.95.981213203746.8863C-100000@current1.whistle.com> Delivered-To: vmailer-current@freebsd.org X-Uidl: 1b358c9d32d6f0710962374315794de3 X-Loop: FreeBSD.ORG Mime-Version: 1.0 In-Reply-To: <8711.913504842@critter.freebsd.dk> Cc: current, isdn Date: Mon, 14 Dec 1998 04:39:38 GMT how about porting the whole shebang to whistle's 'streams' replacement.. we could probably supply the frame relay and ppp packetizer nodes along with the framework and tools... s On Sun, 13 Dec 1998, Poul-Henning Kamp wrote: > > I think I have finally found out what the problem is with the state > machine in the if_sppp implementation. Whoever wrote the implementation > didn't carefully consider the inter-layer calls tls and tlf. > > If one applies a lot of patches like this one: > > case STATE_OPENED: > - (cp->tld)(sp); > sp->rst_counter[cp->protoidx] = 0; > sppp_cp_change_state(cp, sp, STATE_STOPPING); > + (cp->tld)(sp); > goto sta; > break; > > Then things actually start to make sense... > > The problem is that the tld and tlf functions often just call the > pp_up and pp_down routines directly, and therefore most if not all > of the expected up and down events happen in the previous state > as opposed to the next state. > > Flipping it around like I have done above, on the other hand, may > not be a good idea either, since it means we can nest another layer > on the stack and get somewhat confused on the way down. > > It is quite obvious that this will need some more work to sort out, > anybody interested in participating ? > > > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop." > "ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812140555.GAA09116>