Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Jan 2026 14:28:29 -0500
From:      John Baldwin <jhb@FreeBSD.org>
To:        Warner Losh <imp@bsdimp.com>, =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@freebsd.org>
Cc:        Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 7f8b4db9e001 - main - github: Add more context to pull requests
Message-ID:  <1a21abcc-1d3a-4f89-a071-6d54d9b60653@FreeBSD.org>
In-Reply-To: <CANCZdfoMFRQQddkptdrrWvYxbuDpnvHYDYKFKYD3AnJqS-iu2Q@mail.gmail.com>
References:  <6964a4b0.3d7cb.74aa5260@gitrepo.freebsd.org> <6e64a14f-1fa0-45ec-b73b-e84f1dbb8153@FreeBSD.org> <CANCZdfofLubYy5%2BWonHRjBodg-u94-FGZft4k0mH6emtcW1Jzw@mail.gmail.com> <86jyxkfeo9.fsf@ltc.des.dev> <CANCZdfoMFRQQddkptdrrWvYxbuDpnvHYDYKFKYD3AnJqS-iu2Q@mail.gmail.com>

index | next in thread | previous in thread | raw e-mail

On 1/14/26 10:38, Warner Losh wrote:
> On Wed, Jan 14, 2026 at 7:32 AM Dag-Erling Smørgrav <des@freebsd.org> wrote:
> 
>> Warner Losh <imp@bsdimp.com> writes:
>>> John Baldwin <jhb@freebsd.org> writes:
>>>> sys/crypto isn't really the same.  We store the generated OpenSSL
>>>> assembly files there for use by ossl(4), but most of sys/crypto is
>>>> not vendored (e.g. ccp, the non-assembly ossl bits, aesni are all
>>>> just bespoke).
>>> That's the beauty of this: We can have whatever we want here...  These
>>> were placeholders until we had more nuanced things. I see things like
>>> openssh in crypto too, so many things are vendored there, in addition
>>> to the mire of inconsistency...
>>
>> crypto is nearly fully vendored, sys/crypto is mostly not, don't confuse
>> the two...
>>
> 
> Sure. So what's the actionable suggestion?

I would just remove it from the list, but I can maybe take a stab at that.
There are a few subdirs in there that are vendored, so perhaps I can
just adjust the list to be those.

-- 
John Baldwin



home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1a21abcc-1d3a-4f89-a071-6d54d9b60653>