Date: Mon, 13 Jul 2020 09:51:39 -0400 From: Allan Jude <allanjude@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r363103 - head/usr.sbin/bsdinstall/scripts Message-ID: <06373f3c-bbe9-2c3b-19f8-b343852c86c9@freebsd.org> In-Reply-To: <3FAAA225-5092-4861-AC61-157417F8FB6F@gmail.com> References: <202007111720.06BHKHUE005504@repo.freebsd.org> <3FAAA225-5092-4861-AC61-157417F8FB6F@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VkmLsv9haLxhkGeUVsdTFgWjlSNJ567xV Content-Type: multipart/mixed; boundary="ECsWgFbKAW4urPtXhISgSMBXiO7wAWrqm"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Message-ID: <06373f3c-bbe9-2c3b-19f8-b343852c86c9@freebsd.org> Subject: Re: svn commit: r363103 - head/usr.sbin/bsdinstall/scripts References: <202007111720.06BHKHUE005504@repo.freebsd.org> <3FAAA225-5092-4861-AC61-157417F8FB6F@gmail.com> In-Reply-To: <3FAAA225-5092-4861-AC61-157417F8FB6F@gmail.com> --ECsWgFbKAW4urPtXhISgSMBXiO7wAWrqm Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2020-07-12 13:32, Enji Cooper wrote: >=20 >> On Jul 11, 2020, at 10:20 AM, Allan Jude <allanjude@freebsd.org> wrote= : >> >> Author: allanjude >> Date: Sat Jul 11 17:20:17 2020 >> New Revision: 363103 >> URL: https://svnweb.freebsd.org/changeset/base/363103 >> >> Log: >> bsdinstall: only kill the dhclient for the interface we are restartin= g >> >> PR: 205821 >> Reported by: mjg >> MFC after: 2 weeks >> Sponsored by: Klara Inc. >> Event: July 2020 Bugathon >> >> Modified: >> head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 >=20 > Allan, > Thank you so very much for doing this!!! This has been an annoying nit= pick of mine with sysinstall/bsdinstall, for many moons :). > It looks like equivalent logic doesn=E2=80=99t need to be implemented = for IPv6. Yay :). > Cheers! > -Enji >=20 Someone else wrote the patch, although I had a similar idea previously. Mark Johnston came up with the pkill -F part, that made it only kill dhclient for the correct interface. --=20 Allan Jude --ECsWgFbKAW4urPtXhISgSMBXiO7wAWrqm-- --VkmLsv9haLxhkGeUVsdTFgWjlSNJ567xV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJfDGbuAAoJEBmVNT4SmAt+Xu0QAKzgTCEPBKzBALrmfdrhLixK O9Ag62OllBxwZRFFmNJme8gm3tISLsoxGZtD/2UHAtAcFhALYwEDSOAu+63qo38o Ft7PwX4d82rWZXyHdJN7r05DVH0zguVnISohR5duCrl39sgGBXv1roO3kJXlGRcs SI2YyEggc7iohJM6WWV8Ca7T6jhf60rMV5C09RoclDO/zz4A8YO/F4tiN1tVnCX0 O8xCP4UZS4+tN/O0s/gQdO6lkwPcBaOBzZ8JCJ0x0lpP1qS8kV9+grAmJkd8hMBM b2skDpEB6FQb6vq1nEgBBHYpPG3GBM2UU1Chn2vQFIDItLIzcyZLosk0nb/LF40z YIMhPjp8fInMbNKUVM0bfYw6z7IiWDGelMx7TUzc2TQIV3O7i+I3QkIZkgaYSeN6 fMidUu6GlPq1YXnc86CGuiIrnjRaS6WnjT6siYjZjC6ndLiSZkog4K3bOA7Sk7LE gQKROUqaPMq5lRh7NVMx8vhZ+pQUlJzDUbaYKn+5+cHIlFBgcpqE8qjLgOA3QnYw wr/GCLoFj+2xwHH4bne9SwWnlOH45N7/kAnmwmbGjwWNwDLIGwIiGxOAqJ3hWJR1 nARNoIjFq8ASI9KM1TtL8X0h3ZgM4zZdp59gecC8wBdaHjyBE4EGQH3opief3OGG wCGxbN5S/AfmlarjLuzD =i+Lb -----END PGP SIGNATURE----- --VkmLsv9haLxhkGeUVsdTFgWjlSNJ567xV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?06373f3c-bbe9-2c3b-19f8-b343852c86c9>