Date: Thu, 6 Jun 2024 07:24:52 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Michael Osipov <michaelo@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: git: 0e0919db966a - stable/14 - periodic.conf: remove long deprecated security_daily_compat_var() Message-ID: <894B0AFB-A554-456B-94E8-8282D7A5E879@gmail.com> In-Reply-To: <f8213280-dc94-4064-b736-eca66ccd1a78@FreeBSD.org> References: <f8213280-dc94-4064-b736-eca66ccd1a78@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 6, 2024, at 00:20, Michael Osipov <michaelo@freebsd.org> wrote: >=20 > =EF=BB=BFOn 2024-06-05 17:55, Enji Cooper wrote: >>>> On Jun 5, 2024, at 1:07=E2=80=AFAM, Michael Osipov <michaelo@FreeBSD.or= g> wrote: >>>=20 >>> The branch stable/14 has been updated by michaelo: >>>=20 >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D0e0919db966a83efc696d19b3= 9a5962500e6ad46 >>>=20 >>> commit 0e0919db966a83efc696d19b39a5962500e6ad46 >>> Author: Michael Osipov <michaelo@FreeBSD.org> >>> AuthorDate: 2024-04-15 11:05:17 +0000 >>> Commit: Michael Osipov <michaelo@FreeBSD.org> >>> CommitDate: 2024-06-05 08:05:54 +0000 >>>=20 >>> periodic.conf: remove long deprecated security_daily_compat_var() >>>=20 >>> This function is documented to be gone in after 11. Time to remove th= is >>> compat shim. >>>=20 >>> PR: 275296 >>> Reviewed by: jrm (mentor) >>> MFC after: 1 month >>> Differential Revision: https://reviews.freebsd.org/D44796 >>>=20 >>> (cherry picked from commit aa48259f337100e79933d660fec8856371f761ed) >> It=E2=80=99s kind of unfortunate that this didn=E2=80=99t just break peri= odic for folks that rely on these compat variables prior to their removal. >=20 > Enji, >=20 > we talked about this with Baptiste a couple of weeks ago. He fixed pkg and= deep-analyzed all ports for possible issues. All clean and we so no issue b= ackporting it. Also the removed function has been issuing a warning on every= call, did you miss it? Hi Michael, I haven=E2=80=99t missed these messages in the past (I pay WAYYY too muc= h attention to console noise =F0=9F=98=82). My concern is that I=E2=80=99ve s= een warnings like these be missed by others (in particular when FreeBSD is u= sed in a dev/embedded environment), since issues like this are lost in the o= verall =E2=80=9Csea of noise=E2=80=9D that gets dumped out to the console (p= eriodic output doesn=E2=80=99t even go to the console by default since it=E2= =80=99s invoked by cron, so it=E2=80=99s sort of worse=E2=80=A6). One way to mitigate this issue (in my mind) is to document this removal i= n the Release Notes, so maybe (hopefully!) someone might read the RNs, notic= e the change, and adjust their configs to use the updated variables =F0=9F=99= =82. Cheers! -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?894B0AFB-A554-456B-94E8-8282D7A5E879>