Date: Wed, 11 Aug 2004 17:50:52 +0000 From: Bosko Milekic <bmilekic@FreeBSD.org> To: Andre Oppermann <andre@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c raw_ip.c tcp_hostcache.c tcp_subr.c tcp_syncache.c udp_usrreq.c Message-ID: <20040811175052.GA37093@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Please be careful here. The reason they were NOFREE before was because the original zone code was implicitly nofree. If these structures need to be type stable, then you just broke them with this commit. So are you sure that they absolutely do not need to be type stable? -Bosko andre 2004-08-11 17:08:32 UTC FreeBSD src repository Modified files: sys/netinet ip_divert.c raw_ip.c tcp_hostcache.c tcp_subr.c tcp_syncache.c udp_usrreq.c Log: Remove the UMA_ZONE_NOFREE flag to all uma_zcreate() calls in the IP and TCP code. This flag would have prevented giving back excessive free slabs to the global pool after a transient peak usage.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040811175052.GA37093>