Date: Fri, 24 May 2013 20:08:47 +0400
From: "Anton Yuzhaninov" <ayuzhaninov@openstat.ru>
To: FreeBSD-gnats-submit@freebsd.org
Subject: ports/178952: [PATCH] ports-mgmt/portlint: warn about ${SITE_PERL} in depends
Message-ID: <E1UfuXw-0005sM-43@mail.openstat.ru>
Resent-Message-ID: <201305241610.r4OGA1GG007340@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 178952
>Category: ports
>Synopsis: [PATCH] ports-mgmt/portlint: warn about ${SITE_PERL} in depends
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri May 24 16:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Anton Yuzhaninov
>Release: FreeBSD 10.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD citrin.office.vega.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #2 r250144: Wed May 1 21:01:29
>Description:
Warn about using ${SITE_PERL} in depends:
1. bsd.perl.mk should be included not for all ports. Conditional inclusion of
bsd.perl.mk was reverted in http://svnweb.freebsd.org/changeset/ports/279560
because of widespread ${SITE_PERL} usage.
2. Such ports was fixed for most ports, see e. g.:
http://svnweb.freebsd.org/changeset/ports/305672
but new ones appeared since...
Generated with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:
--- portlint-2.14.3_1.patch begins here ---
diff -ruN /usr/ports//ports-mgmt/portlint/Makefile ./Makefile
--- /usr/ports//ports-mgmt/portlint/Makefile 2013-04-29 03:18:23.000000000 +0400
+++ ./Makefile 2013-05-24 19:43:05.000000000 +0400
@@ -6,6 +6,7 @@
PORTNAME= portlint
PORTVERSION= 2.14.3
+PORTREVISION= 1
CATEGORIES= ports-mgmt
MASTER_SITES= # none
DISTFILES= # none
diff -ruN /usr/ports//ports-mgmt/portlint/src/portlint.pl ./src/portlint.pl
--- /usr/ports//ports-mgmt/portlint/src/portlint.pl 2013-04-29 03:18:23.000000000 +0400
+++ ./src/portlint.pl 2013-05-24 19:39:59.000000000 +0400
@@ -1134,6 +1134,14 @@
"USE_PERL5.");
}
+ # Check for ${SITE_PERL} in depends
+ if ($m{'dep'} =~ m|^(\${SITE_PERL}/.*)$|) {
+ &perror("WARN", $file, -1, "dependency to $1 ".
+ "listed in $j. consider using p5-Example-Package-Name>=0. See ".
+ "http://www.freebsd.org/doc/en/books/porters-handbook/using-perl.html".
+ " for more details.");
+ }
+
# check USE_ICONV
if ($m{'dep'} =~ /^(iconv\.\d+)$/) {
&perror("WARN", $file, -1, "dependency to $1 ".
--- portlint-2.14.3_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1UfuXw-0005sM-43>