Date: Fri, 22 Aug 2008 09:22:13 -0700 From: Sam Leffler <sam@freebsd.org> To: Pyun YongHyeon <yongari@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h Message-ID: <48AEE7B5.7090700@freebsd.org> In-Reply-To: <200808220647.m7M6lAeL097786@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Pyun YongHyeon wrote:
> yongari 2008-08-22 06:46:55 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/dev/bfe if_bfe.c if_bfereg.h
> Log:
> SVN rev 181994 on 2008-08-22 06:46:55Z by yongari
>
> Add a new sysctl node 'dev.bfe.N.stats' that shows various MAC
> counters for Rx/Tx statistics. Various counters in ifnet is also
> updated with these hardware counters.
>
>
Can we not add stuff like that spews output to the console? I much
prefer to see a tool that dumps the stats and if you need to get to them
w/o the tool then consider adding a ddb cmd. We're just about to get
the ability to add ddb cmds in loadable modules which was the only
reason not to leverage ddb for stuff like this.
I see this done in several drivers and hate it. I'd like to see this
approach not be copied in the future.
Sam
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48AEE7B5.7090700>