Date: Fri, 11 Mar 2016 09:28:33 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: svn commit: r296589 - head/sys/dev/fdc Message-ID: <56E30041.3020804@FreeBSD.org> In-Reply-To: <CANCZdfqQQwtC=30WFc_hcabnR06Vnk=esHACDCBo0-WYdVs6KA@mail.gmail.com> References: <201603100033.u2A0X6uN027771@repo.freebsd.org> <56E1F72D.7000002@FreeBSD.org> <CANCZdfq5zHhaR5NvasJRTz%2BVUk1kq-cMb6SxNrYeEr2-nV6wdw@mail.gmail.com> <CANCZdfqQQwtC=30WFc_hcabnR06Vnk=esHACDCBo0-WYdVs6KA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --22grvUsp1kwLkApMC3HVEJH8q6leL9f61 Content-Type: multipart/mixed; boundary="uxkN9qKeQ4cTsvmAR5wwJL38LswhouETs" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Warner Losh <imp@freebsd.org> Message-ID: <56E30041.3020804@FreeBSD.org> Subject: Re: svn commit: r296589 - head/sys/dev/fdc References: <201603100033.u2A0X6uN027771@repo.freebsd.org> <56E1F72D.7000002@FreeBSD.org> <CANCZdfq5zHhaR5NvasJRTz+VUk1kq-cMb6SxNrYeEr2-nV6wdw@mail.gmail.com> <CANCZdfqQQwtC=30WFc_hcabnR06Vnk=esHACDCBo0-WYdVs6KA@mail.gmail.com> In-Reply-To: <CANCZdfqQQwtC=30WFc_hcabnR06Vnk=esHACDCBo0-WYdVs6KA@mail.gmail.com> --uxkN9qKeQ4cTsvmAR5wwJL38LswhouETs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 3/10/2016 9:14 PM, Warner Losh wrote: >=20 >=20 > On Thu, Mar 10, 2016 at 6:58 PM, Warner Losh <imp@bsdimp.com > <mailto:imp@bsdimp.com>> wrote: >=20 >=20 > On Mar 10, 2016 3:37 PM, "Bryan Drewery" <bdrewery@freebsd.org > <mailto:bdrewery@freebsd.org>> wrote: > > > > On 3/9/16 4:33 PM, Warner Losh wrote: > > > Author: imp > > > Date: Thu Mar 10 00:33:06 2016 > > > New Revision: 296589 > > > URL: https://svnweb.freebsd.org/changeset/base/296589 > > > > > > Log: > > > Stop assuming that bio_cmd is a bit field. > > > > > > Differential Revision: https://reviews.freebsd.org/D5587 > > > > > > Modified: > > > head/sys/dev/fdc/fdc.c > > > > > > Modified: head/sys/dev/fdc/fdc.c > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/sys/dev/fdc/fdc.c Thu Mar 10 00:27:10 2016 =20 > (r296588) > > > +++ head/sys/dev/fdc/fdc.c Thu Mar 10 00:33:06 2016 =20 > (r296589) > > > @@ -941,7 +941,7 @@ fdc_worker(struct fdc_data *fdc) > > > /* Disable ISADMA if we bailed while it was active */ > > > if (fd !=3D NULL && (fd->flags & FD_ISADMA)) { > > > isa_dmadone( > > > - bp->bio_cmd & BIO_READ ? ISADMA_READ : > ISADMA_WRITE, > > > + bp->bio_cmd =3D=3D BIO_READ ? ISADMA_READ : > ISADMA_WRITE, > > > > I think we should have some kind of file (like ports CHANGES) tha= t > lists > > subtle KPI changes. This and the bio bzero change were easily mi= ssed > > and could lead to who-knows-what downstream for vendors or even > > out-of-tree modules. >=20 > True. However, these have never been documented one way or another.= =2E.. >=20 > And this change isn't a change yet... >=20 > I'd love a kpi change file. This is but one of many. We'd need > someone clueful to watch the tree and remind people to add things t= o it. >=20 > I'm also working on documenting our storage api so that people know= > better what is defined, vs what's there and subject to change. >=20 > Re-reading this, I wasn't very clear: >=20 > I think we need this file. > I think we need someone else (not me) to spearhead it and police change= s > I think that the sooner we start the better. > Can I get a volunteer? I don't mind policing it. I'll bring it up on arch@ just to be sure no one objects for some reason. It was also pointed out to me that bio_cmd was never a bitfield and lacked documentation. However I still think it is worth having a file like this. Even my share/mk changes have been subtle enough to break downstream where I don't feel UPDATING is the proper place. --=20 Regards, Bryan Drewery --uxkN9qKeQ4cTsvmAR5wwJL38LswhouETs-- --22grvUsp1kwLkApMC3HVEJH8q6leL9f61 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJW4wBCAAoJEDXXcbtuRpfPu7oH/0uMnK8t0dIFYwaWV9Tm/G+O X+izHjCQ/9sk7m4K0y7XX+cZS0ODepKoTdTACmFsjvk3cTmiqQ7d8rDPhUsHT+jj zch5j1wnsJOxsLtU3VWKTIJKunwhTzLo0pIPNxOceJLv1iFLv/SDMVy+0WYdCQMM 9jnxa/8Oi8mE4CfGqvQsQAG//qsAfH+TO5cXQPqMNxHslpTOzL1jhoniYjNZiSN5 +5yZ66kCMMsnwmtfRpmZEZZHq54rcVIFd2gKkgRrRw8cUBVh+gbagGpF1S1D94+m pm1shWW2OGi6RcTUUQaF5HkQuKczoHAufQAE8OyAPiWIMwUm8SmDwHGV13hlN8U= =aezR -----END PGP SIGNATURE----- --22grvUsp1kwLkApMC3HVEJH8q6leL9f61--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56E30041.3020804>