Date: Thu, 26 Jan 2017 14:31:21 +0000 From: "David_A_Bright_DELL.com (David A. Bright)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h Message-ID: <67b43720aa445cb7b82db14eb43dd6e5@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-ehgwxeotuhsw6eo52uz6-req@FreeBSD.org> References: <differential-rev-PHID-DREV-ehgwxeotuhsw6eo52uz6-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
David_A_Bright_DELL.com accepted this revision. David_A_Bright_DELL.com added a reviewer: David_A_Bright_DELL.com. David_A_Bright_DELL.com added inline comments. This revision has a positive review. INLINE COMMENTS > decui_microsoft.com wrote in if_var.h:407 > I was trying to keep the consistency with Line 392, 395, 401 and 404. > I would tend to leave the patch as it is, if you won't strongly object to it. :-) No objection to "Interface ..." but then I'd use "Interface up/down event" (the "if" in "ifdown" meaning "interface" is redundant). But, then, this is a nit. I don't strongly object to the patch as-is. > decui_microsoft.com wrote in if_var.h:408 > Actually the 2 lines do line up. > The visual confusion is due to the nasty Tab issue in the case of a patch. :-) > > With "set list" in my Vim, the lines of the file net/if_var.h (rather than the patch with a leading + at the beginning of the lines) shows > > #define IFNET_EVENT_UP^I^I0$ > #define IFNET_EVENT_DOWN^I1$ > > ^I means a Tab. > $ means a CR-LF. Hmmm, you are right; Phabricator is deceiving me. They don't line up at all in the diff display it shows me, but you are right that they do in code. Sorry about that. (Just a note that style(9) says to use just a single tab between name and value, which would mean they wouldn't line up. See similar situation at lines 185-186.) REVISION DETAIL https://reviews.freebsd.org/D9345 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: decui_microsoft.com, hselasky, sepherosa_gmail.com, cem, np, kmacy, kib, honzhan_microsoft.com, howard0su_gmail.com, jhb, ae, delphij, royger, glebius, gnn, rwatson, David_A_Bright_DELL.com Cc: David_A_Bright_DELL.com, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?67b43720aa445cb7b82db14eb43dd6e5>