Date: Mon, 9 Sep 2013 07:28:41 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Dag-Erling Sm??rgrav <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255385 - in head/etc: . etc.amd64 Message-ID: <20130909042841.GE41229@kib.kiev.ua> In-Reply-To: <86ioybozic.fsf@nine.des.no> References: <201309080946.r889kNSX050568@svn.freebsd.org> <20130908110410.GZ41229@kib.kiev.ua> <86zjrnedp5.fsf@nine.des.no> <20130908143854.GA41229@kib.kiev.ua> <86ioybozic.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sun, Sep 08, 2013 at 09:59:55PM +0200, Dag-Erling Sm??rgrav wrote:
> How about this, which eliminates the unneeded mappings and installs
> libmap32.conf on powerpc64 as well?
>
> Index: etc/Makefile
> ===================================================================
> --- etc/Makefile (revision 255393)
> +++ etc/Makefile (working copy)
> @@ -50,8 +50,8 @@
> syslog.conf \
> termcap.small
>
> -.if ${MACHINE} == "amd64"
> -BIN1+= etc.${MACHINE}/libmap32.conf
> +.if ${TARGET_ARCH} == "amd64" || ${TARGET_ARCH} == "powerpc64"
> +BIN1+= libmap32.conf
> .endif
>
> .if exists(${.CURDIR}/etc.${MACHINE}/ttys)
> Index: etc/libmap32.conf
> ===================================================================
> --- etc/libmap32.conf (revision 255393)
> +++ etc/libmap32.conf (working copy)
> @@ -1,4 +1,2 @@
> # $FreeBSD$
> -/lib /lib32
> -/usr/lib /usr/lib32
> /usr/lib/private /usr/lib32/private
> Index: etc/etc.amd64/libmap32.conf
> ===================================================================
> --- etc/etc.amd64/libmap32.conf (revision 255393)
> +++ etc/etc.amd64/libmap32.conf (working copy)
> @@ -1,4 +0,0 @@
> -# $FreeBSD$
> -/lib /lib32
> -/usr/lib /usr/lib32
> -/usr/lib/private /usr/lib32/private
This looks fine.
>
> We should have a knob that says "this arch supports 32-bit emulation" so
> we don't have to edit a million files when somebody implements 32-bit
> emulation on a new arch (such as mips64 or arm64).
>
The knob does not exists probably because there is the build32 stage.
Are you going to remove COMPAT_32BIT conditional from the rtld.c ?
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iQIcBAEBAgAGBQJSLU54AAoJEJDCuSvBvK1BR1MQAIa7mReJh9K4I0DrnxiTTnpp
bZIWVlk55PEdRm/VV/x2kx0MTPnDmgY4PcPEVU6ph67slzA4qw1eE8/lC0cNYA9D
KkrRirm/lY5vV2A5BN9qA2GW1kn2qsDHfBT2NhckGyG3mI5lRbplETLzTNXnSvka
/rBVl/qDgFKOeS1emNFx+BSMHJ27hwuHSQwZ+33v2mE8GCKypIML5BQFs6rs1/5N
ZMktIyTW9zDlIDxlHEiYjxXriqJFkNK5APPM80CMx57PfjF4sSmbVvMCJhhqD2t2
iMrNPKe9C1l0kj4vJFjRac9fLCPocJBzGgP7X3BKhg9tE9xP/oUufAWb1ygmGmuH
ijWt3tNoc6l9YV5amrk1KBlmSV9DTKHcj0PWzrAAlrgLLSHkjHr2xNVYDJ7v16Sl
IZHj8wfEyXsQ0os6H7IKrAh6KfEGPS2p25fDRkutR0TOgcn8v/VBPMxZbcsNk3nn
rDNvwS9GIyvwVASKwdijYZlhZ+E78OzA94BuK/q7UGtkOZoysFGs4WQpAsWyUAGI
YqOWuv99xSm/RFplhrPkxcWXdnZFJlhMh/LC9Zy07qkru0gOjaDO8QOyD6dN8f/g
BNpoIFQC87/Ff+MEH2S8VUQRvUG0182jTdj0o8h9T17sQmza4LDWtfpZn5I0xkX9
f+QoP88Ll1Dz2FLmk4Zd
=KZBQ
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130909042841.GE41229>