Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 14 Jan 2026 20:09:24 +0000
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Warner Losh <imp@bsdimp.com>
Cc:        Ed Maste <emaste@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 7f8b4db9e001 - main - github: Add more context to pull requests
Message-ID:  <99EC31C7-78CD-43E3-B879-63E4FD6F86C5@freebsd.org>
In-Reply-To: <CANCZdfoU1RZh=YAy5YrKjqN5XMHOacBaL_vAfFJYUSJfMA9XMQ@mail.gmail.com>
References:  <6964a4b0.3d7cb.74aa5260@gitrepo.freebsd.org> <CAPyFy2Df_70OPuYM4_2k7mbBpvBrhS1%2BeEFm_i0Pb0Q1ckHEwg@mail.gmail.com> <CANCZdfrcFnE-J_6gsKgxpWDu1jjScYXpDTqW%2BfvNTpMrKZp58A@mail.gmail.com> <DBEC9EBD-F837-4FDB-8EF7-AE78E2D69462@freebsd.org> <CANCZdfoU1RZh=YAy5YrKjqN5XMHOacBaL_vAfFJYUSJfMA9XMQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail 

On 14 Jan 2026, at 18:57, Warner Losh <imp@bsdimp.com> wrote:

> 
> 
> On Wed, Jan 14, 2026 at 11:22 AM Jessica Clarke <jrtc27@freebsd.org> wrote:
> On 14 Jan 2026, at 18:16, Warner Losh <imp@bsdimp.com> wrote:
> > On Wed, Jan 14, 2026 at 11:12 AM Ed Maste <emaste@freebsd.org> wrote:
> >> On Mon, 12 Jan 2026 at 02:37, Warner Losh <imp@freebsd.org> wrote:
> >> >
> >> > The branch main has been updated by imp:
> >> >
> >> > URL: https://cgit.FreeBSD.org/src/commit/?id=7f8b4db9e001d94974a081e5fd58c4f3994429cb
> >> >
> >> > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb
> >> > Author:     Warner Losh <imp@FreeBSD.org>
> >> > AuthorDate: 2026-01-10 16:20:20 +0000
> >> > Commit:     Warner Losh <imp@FreeBSD.org>
> >> > CommitDate: 2026-01-12 07:18:11 +0000
> >> >
> >> >     github: Add more context to pull requests
> >> >
> >> >     Add code to fetch and decode CODEOWNERS and automatically @ people in
> >> >     the review.
> >> 
> >> Does this not just duplicate existing GitHub functionality; it should
> >> be automatically assigning reviewers to a pull request based on
> >> CODEOWNERS AFAICT.
> > 
> > No. It's not doing that right now at all. That's why I added it. Maybe there's a simpler way, but it wasn't tagging people automatically.
> 
> Only users with write permission for the GitHub repo work.
> 
> What I've done? Or CODEOWNERS? It works for me, but I'm extra special in github land.

CODEOWNERS; answering Ed’s question. As far as I know your code should work for tagging anyone.

Jessica
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?99EC31C7-78CD-43E3-B879-63E4FD6F86C5>