Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Jan 2024 22:43:43 +0100
From:      Moin Rahman <bofh@freebsd.org>
To:        Hiroki Sato <hrs@freebsd.org>
Cc:        "ports-committers@freebsd.org" <ports-committers@FreeBSD.org>, "dev-commits-ports-all@freebsd.org" <dev-commits-ports-all@FreeBSD.org>, "dev-commits-ports-main@freebsd.org" <dev-commits-ports-main@FreeBSD.org>
Subject:   Re: git: 9a5a5a037897 - main - japanese/kterm: Sanitize MANPREFIX
Message-ID:  <0CEA16BF-9286-409B-AE3B-E3A13A63735C@freebsd.org>
In-Reply-To: <20240123.063634.1428580388567496859.hrs@FreeBSD.org>
References:  <202401222027.40MKRVaH012805@gitrepo.freebsd.org> <20240123.060027.1610312468979447172.hrs@FreeBSD.org> <372CB45E-1608-41D9-B43F-8D2BE834C68E@freebsd.org> <20240123.063634.1428580388567496859.hrs@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_84FD3709-387B-4B9F-A692-182F22148E83
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On Jan 22, 2024, at 10:36 PM, Hiroki Sato <hrs@freebsd.org> wrote:
>=20
> Moin Rahman <bofh@freebsd.org> wrote
>  in <372CB45E-1608-41D9-B43F-8D2BE834C68E@freebsd.org>:
>=20
> bo>
> bo>
> bo> > On Jan 22, 2024, at 10:00 PM, Hiroki Sato <hrs@freebsd.org> =
wrote:
> bo> >
> bo> > Muhammad Moinur Rahman <bofh@FreeBSD.org> wrote
> bo> >  in <202401222027.40MKRVaH012805@gitrepo.freebsd.org>:
> bo> >
> bo> > bo> The branch main has been updated by bofh:
> bo> > bo>
> bo> > bo> URL: =
https://cgit.FreeBSD.org/ports/commit/?id=3D9a5a5a0378972be4f6b9d4d4c67c68=
baaebb1daa
> bo> > bo>
> bo> > bo> commit 9a5a5a0378972be4f6b9d4d4c67c68baaebb1daa
> bo> > bo> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> bo> > bo> AuthorDate: 2024-01-22 19:37:27 +0000
> bo> > bo> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> bo> > bo> CommitDate: 2024-01-22 20:26:42 +0000
> bo> > bo>
> bo> > bo>     japanese/kterm: Sanitize MANPREFIX
> bo> > bo>
> bo> > bo>     Approved by:    portmgr (blanket)
> bo> >
> bo> > ...
> bo> >
> bo> > bo> -man/ja.UTF-8/man1/kterm.1.gz
> bo> > bo> -man/man1/kterm.1.gz
> bo> > bo> +share/man/ja/man1/kterm.1.gz
> bo> > bo> +share/man/man1/kterm.1.gz
> bo> >
> bo> > Why does ja.UTF-8 need to be replaced with ja?  The man(1) =
utility
> bo> > searches man/<lang_country.charset> and man/<lang.charset>, not
> bo> > man/<lang>.
> bo> >
> bo> > -- Hiroki
> bo>
> bo> That's only applicable for base. Apart from that and ${PREFIX}/man
> bo> and ${PREFIX}/share/man everything has to be added to the MANPATH.
>=20
> You mean ${PREFIX}/share/man/ja needs to be added to MANPATH manually?
>=20
> ja.UTF-8 just works even for /usr/local by default as far as I can
> check.  I got the following when entering "man -d kterm" and there is
> /usr/local/share/man/ja.UTF-8 and LANG=3Dja_JP.UTF-8:
>=20
> -- Using architecture: amd64:amd64
> -- Using pager: less
> -- Searching PATH for man directories
> --   Adding /usr/share/man to manpath
> --   Adding /usr/local/share/man to manpath
> --   Adding /usr/local/man to manpath
> -- Adding default manpath entries
> --   Adding /usr/share/openssl/man to manpath
> -- Parsing config file: /usr/local/etc/man.d/perl5.conf
> --   Adding /usr/local/lib/perl5/site_perl/man to manpath
> --   Adding /usr/local/lib/perl5/5.36/perl/man to manpath
> -- Using manual path: =
/usr/share/man:/usr/local/share/man:/usr/local/man:/usr/share/openssl/man:=
/usr/local/lib/perl5/site_perl/man:/usr/local/lib/perl5/5.36/perl/man
> -- Using manual sections: 1:8:2:3:3lua:n:4:5:6:7:9:l
> -- Using locale paths: ja_JP.UTF-8:ja.UTF-8:en.UTF-8:.
> -- Using standard page width
> -- Searching for "kterm"
> --     Found manpage "/usr/local/share/man/ja.UTF-8/man1/kterm.1.gz"
> --     Skipping catpage: not found or old
> -- Command: /usr/bin/gzcat =
"/usr/local/share/man/ja.UTF-8/man1/kterm.1.gz" | mandoc  | less
>=20
> And the following when there is /usr/local/share/man/ja and
> LANG=3Dja_JP.UTF-8:
>=20
> -- Using architecture: amd64:amd64
> -- Using pager: less
> -- Searching PATH for man directories
> --   Adding /usr/share/man to manpath
> --   Adding /usr/local/share/man to manpath
> --   Adding /usr/local/man to manpath
> -- Adding default manpath entries
> --   Adding /usr/share/openssl/man to manpath
> -- Parsing config file: /usr/local/etc/man.d/perl5.conf
> --   Adding /usr/local/lib/perl5/site_perl/man to manpath
> --   Adding /usr/local/lib/perl5/5.36/perl/man to manpath
> -- Using manual path: =
/usr/share/man:/usr/local/share/man:/usr/local/man:/usr/share/openssl/man:=
/usr/local/lib/perl5/site_perl/man:/usr/local/lib/perl5/5.36/perl/man
> -- Using manual sections: 1:8:2:3:3lua:n:4:5:6:7:9:l
> -- Using locale paths: ja_JP.UTF-8:ja.UTF-8:en.UTF-8:.
> -- Using standard page width
> -- Searching for "kterm"
> --     Found manpage "/usr/local/share/man/man1/kterm.1.gz"
> --     Skipping catpage: not found or old
> -- Command: /usr/bin/gzcat "/usr/local/share/man/man1/kterm.1.gz" | =
mandoc  | less
>=20
> This is the reason why I changed the pathname from ja to ja.UTF-8 in
> the previous commit.  Am I missing something?
Am not sure. I might be wrong too as haven't played with locales for a =
while.

But as like as other commits in these batches the primary purpose was to
move man pages to share. And this was secondary issue.

So if you are confident feel free to switch back but keeping everything
under ${PREFIX}/share/man.

Kind regards,
Moin

> -- Hiroki


--Apple-Mail=_84FD3709-387B-4B9F-A692-182F22148E83
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmWu4Y9fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE
Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA
vJEXQA//YrW1EdRV3w4OEkAJPWv+sEITDjH4+FTgHgpA1oPtNC32IA+dxFw8tAUM
srtq6XvHVrWjI7tjQWkaigde5cXIpFbZc9S71Ytw/UJ83qv6NOPfiztb/Vvp7R3x
XyK39qOJdhF0MZYPQWpupESLGoHicPFf8vnxlT0Rxz/get+XHDADeTa1/ki3q2aJ
milG/kaR18TaD0tpIywuTTXuiZS/FccdRitL7Qz+JREx7Il69bpPq4YpjYYoSChw
1A9UCuexxQ8boIXZHEmN7mUNhcySMoHcopa2keJfCB62IlZN4BTxFyew7yzUqnF1
f41k6sSeJahUegj7Yi0dnBAMw/+zMZHaJK6Fd057iDNeuhJMYxFKjizK7B752Hkx
G5qEtRtcAiMvAGY11DEnU06LbiCXvVRgrVC16bWdUp8Vs4372Fb2RSlVHNW/S0/I
fwv1j52KhOCO2t+ivFeBdPTdd4htjU5safYrzPcx4uqtKL1dCR/scYKK+y/K/yyq
pRJ8ZyQLh+jvc5EcnFdKnakYDfRrx+7cS7ptuSueEh2Nwk5sN7P7xBknW4QwTIeg
mIDydnHK+MovpwgwMKMSvuYY6UreYP8RegGP422UBSJcK8pQqhHjY/j3sfHEiFo7
Dx7QejtRmzh2GAceaXQ1LxWLu2ffUpJeM3pS2FWVtGrmnf2UJZ4=
=inEx
-----END PGP SIGNATURE-----

--Apple-Mail=_84FD3709-387B-4B9F-A692-182F22148E83--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0CEA16BF-9286-409B-AE3B-E3A13A63735C>