Date: Thu, 21 May 2009 11:36:49 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Andre Oppermann <andre@freebsd.org> Cc: rmacklem@uoguelph.ca, freebsd-current@freebsd.org Subject: Re: Socket related code duplication in NFS Message-ID: <alpine.BSF.2.00.0905211135300.25537@fledge.watson.org> In-Reply-To: <alpine.BSF.2.00.0905202102100.25537@fledge.watson.org> References: <4A1460A3.2010202@freebsd.org> <alpine.BSF.2.00.0905202102100.25537@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 May 2009, Robert Watson wrote:
> On Wed, 20 May 2009, Andre Oppermann wrote:
>
>> While working on an optimized soreceive_stream() function [1] and checking
>> the code how it is used I've come across quite a bit of code duplication in
>> the various NFS directories.
>>
>> Socket (read) operations are handled multiple times in a very similar
>> manner in these places:
>
> My recommendation would be to do this analysis against the new NFS client
> and server found in sys/{kgssapi,nlm,fs/{nfs,nfsclient,nfsserver}}, which is
> the NFSv234 implementation. Note in particular that in the new world order
> there's a centralize RPC implementation.
>
> The code you're looking at is a blend of the old NFSv23 client/server
> (nfsclient/nfsserver) and the old NFSv4 client (rpc/nfs4client), all if
> which are on a gradual de-orbit burn.
After re-reading this e-mail, I realize that I'd mislabeled src/sys/rpc as
being only used by the old code -- this is in fact not the case, it's also
used by the new code.
Robert N M Watson
Computer Laboratory
University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0905211135300.25537>