Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Nov 2016 21:24:06 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 214832] if_pflog subrulenr incorrectly set
Message-ID:  <bug-214832-8@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D214832

            Bug ID: 214832
           Summary: if_pflog subrulenr incorrectly set
           Product: Base System
           Version: 11.0-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: andywhite@gmail.com

https://svnweb.freebsd.org/base/releng/11.0/sys/netpfil/pf/if_pflog.c?view=
=3Dmarkup#l224

should set subrulenr to -1, not to 1, when there is no subrule

i.e.

hdr.subrulenr =3D  -1;

NOT

hdr.subrulenr =3D  1;

This is used in tcpdump=20

https://svnweb.freebsd.org/base/releng/11.0/contrib/tcpdump/print-pflog.c?v=
iew=3Dmarkup#l94

to determine there is no subrule and to format output differently.

without this change, you will get output like

rule 0..16777216(match) , instead of the correct output of
rule 0/0(match)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-214832-8>