Date: Fri, 26 Aug 2016 22:20:08 +0200 From: Ed Schouten <ed@nuxi.nl> To: Bryan Drewery <bdrewery@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, Guido Falsi <madpilot@freebsd.org>, svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen Message-ID: <CABh_MKn_Zmr7RGddVLi5gKsU2mO1ZT%2B30xObmJJXyamGbvrfAQ@mail.gmail.com> In-Reply-To: <7faebb9e-897a-0a7e-0ec7-c599e8658095@FreeBSD.org> References: <201608120703.u7C73whf007189@repo.freebsd.org> <1ce79adf-94cc-e5d3-7b8b-0914f2b07512@FreeBSD.org> <CABh_MKnHa-djy_HVEGhCM8xAjOXwrhdP7Sh-Gr6v09nrbS5pnw@mail.gmail.com> <2038784.5k3koFGWFB@ralph.baldwin.cx> <7faebb9e-897a-0a7e-0ec7-c599e8658095@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hey, 2016-08-26 22:04 GMT+02:00 Bryan Drewery <bdrewery@freebsd.org>: > On 8/26/2016 12:57 PM, John Baldwin wrote: >> Alternatively, couldn't you just leave basename out of the libgen patch >> for now and only add it once you do the real symver bump for the >> different version? (That is, just use __generic() for dirname() for >> now since that is the only one that has really changed.) > > Doing this also works. > > I think it was done since the prototype did change as well which > disallows building the old xinstall directly, but in the bootstrap build > it is built with MK_WARNS=no so the error is ignored. That's good to know. I'll land this change in a couple of minutes from now, reverting any of the changes related to basename(). Guido, Bryan, thanks for testing! -- Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKn_Zmr7RGddVLi5gKsU2mO1ZT%2B30xObmJJXyamGbvrfAQ>