Date: Mon, 9 Aug 2010 02:01:52 +0200 From: Attilio Rao <attilio@freebsd.org> To: Randall Stewart <rrs@freebsd.org> Cc: src-committers@freebsd.org, John Baldwin <jhb@freebsd.org>, "Jayachandran C." <jchandra@freebsd.org>, svn-src-all@freebsd.org, Joe Landers <jlanders@vmware.com>, sbruno@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r208165 - in head/sys: kern mips/conf mips/include mips/mips mips/rmi mips/rmi/dev/xlr Message-ID: <AANLkTikAarFgbxgGu-8XG7gh6VidPoVGwva54NN4rcRF@mail.gmail.com> In-Reply-To: <201005161943.o4GJhnTo096839@svn.freebsd.org> References: <201005161943.o4GJhnTo096839@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/5/16 Randall Stewart <rrs@freebsd.org>: > Author: rrs > Date: Sun May 16 19:43:48 2010 > New Revision: 208165 > URL: http://svn.freebsd.org/changeset/base/208165 > > Log: > =C2=A0This pushes all of JC's patches that I have in place. I > =C2=A0am now able to run 32 cores ok.. but I still will hang > =C2=A0on buildworld with a NFS problem. I suspect I am missing > =C2=A0a patch for the netlogic rge driver. > > =C2=A0JC check and see if I am missing anything except your > =C2=A0core-mask changes > Modified: head/sys/kern/subr_smp.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/subr_smp.c =C2=A0 =C2=A0Sun May 16 19:25:56 2010 =C2=A0= =C2=A0 =C2=A0 =C2=A0(r208164) > +++ head/sys/kern/subr_smp.c =C2=A0 =C2=A0Sun May 16 19:43:48 2010 =C2=A0= =C2=A0 =C2=A0 =C2=A0(r208165) > @@ -503,7 +503,10 @@ smp_topo_none(void) > =C2=A0 =C2=A0 =C2=A0 =C2=A0top =3D &group[0]; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_parent =3D NULL; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_child =3D NULL; > - =C2=A0 =C2=A0 =C2=A0 top->cg_mask =3D (1 << mp_ncpus) - 1; > + =C2=A0 =C2=A0 =C2=A0 if (mp_ncpus =3D=3D sizeof(top->cg_mask) * 8) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 top->cg_mask =3D -1; > + =C2=A0 =C2=A0 =C2=A0 else > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 top->cg_mask =3D (1 <<= mp_ncpus) - 1; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_count =3D mp_ncpus; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_children =3D 0; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_level =3D CG_SHARE_NONE; > ... and this is why I particulary hate big commits with complete lack of technical details. This particulary chunk was supposed to fix a nasty and completely MI bug that some users have already met (kern/148698). The complete lack of details didn't help in identify the issue neither that it was a valuable fix. The fix is, however, improper (there is no clear relationship between the multiplication and why that happens) thus I would rather use what Joe has reported in the PR. Thanks, Attilio --=20 Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikAarFgbxgGu-8XG7gh6VidPoVGwva54NN4rcRF>