Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Mar 1996 17:57:18 +0300 (MSK)
From:      =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) <ache@astral.msk.su>
To:        current@freebsd.org, mark@grondar.za
Subject:   secure/lib/libtelnet/Makefile and #ifdef comments
Message-ID:  <KHEz3HnWa2@dt.demos.su>

next in thread | raw e-mail | index | archive | help
There was simple #ifdef comment that don't hurt anybody in old days
(it left from original telnet Makefiles), what happens now:

.if defined(MAKE_EBONES)

CFLAGS+= -DENCRYPTION

.if exists(${DESTDIR}/usr/lib/libkrb.a) && defined(MAKE_EBONES)

ENCRYPTION *can* be defined *without* MAKE_EBONES, encryption
can be RSA, etc and not related to EBONES directly, it is
wrong move. BTW, why is double MAKE_EBONES now?

nocrypt:
.if defined(ENCRYPTION)
	@for i in ${CRYPT_SRC}; do \

Yet one again: nobody define ENCRYPTION variable, such variable
not exists. I don't see any logic here.

There is two solutions exists: finally cleanup telnet/telnetd/libtelnet
makefiles moving them to FreeBSD variant only or back out libtelnet
change.

-- 
Andrey A. Chernov        : And I rest so composedly,  /Now, in my bed,
ache@astral.msk.su       : That any beholder  /Might fancy me dead -
http://dt.demos.su/~ache : Might start at beholding me,  /Thinking me dead.
RELCOM Team,FreeBSD Team :         E.A.Poe         From "For Annie" 1849



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?KHEz3HnWa2>