Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 02 Jun 2014 12:08:21 +0200
From:      "Ronald Klop" <ronald-lists@klop.ws>
To:        "Bjoern A. Zeeb" <bz@freebsd.org>, "Gleb Smirnoff" <glebius@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r266822 - head/sys/netipsec
Message-ID:  <op.xgtnr70mkndu52@ronaldradial.radialsg.local>
In-Reply-To: <20140529034442.GS50679@FreeBSD.org>
References:  <201405282301.s4SN1Kcv020803@svn.freebsd.org> <20140529034442.GS50679@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 29 May 2014 05:44:42 +0200, Gleb Smirnoff <glebius@freebsd.org>  
wrote:

> On Wed, May 28, 2014 at 11:01:20PM +0000, Bjoern A. Zeeb wrote:
> B> Author: bz
> B> Date: Wed May 28 23:01:20 2014
> B> New Revision: 266822
> B> URL: http://svnweb.freebsd.org/changeset/base/266822
> B>
> B> Log:
> B>   Use IPv4 statistics in ipsec4_process_packet() rather than the IPv6
> B>   version.  This also unbreaks the NOINET6 builds after r266800.
> B>
> B> Modified:
> B>   head/sys/netipsec/ipsec_output.c
> B>
> B> Modified: head/sys/netipsec/ipsec_output.c
> B>  
> ==============================================================================
> B> --- head/sys/netipsec/ipsec_output.c	Wed May 28 19:59:27  
> 2014	(r266821)
> B> +++ head/sys/netipsec/ipsec_output.c	Wed May 28 23:01:20  
> 2014	(r266822)
> B> @@ -576,7 +576,7 @@ ipsec4_process_packet(
> B>  		DPRINTF(("%s: unsupported protocol family %u\n",
> B>  				 __func__, dst->sa.sa_family));
> B>  			error = EPFNOSUPPORT;
> B> -			IPSEC6STAT_INC(ips_out_inval);
> B> +			IPSECSTAT_INC(ips_out_inval);
> B>  			goto bad;
> B>  		}
> B>  		error = (*sav->tdb_xform->xf_output)(m, isr, NULL, i, off);
> B> @@ -739,4 +739,4 @@ bad:
> B>  		m_freem(m);
> B>  	return error;
> B>  }
> B> -#endif /*INET6*/
> B> \ No newline at end of file
> B> +#endif /*INET6*/
>
> Is there any reason to keep the line '\ No newline at end of file' when
> it is no longer at the end of the file?
>

The '\ No newline at end of file' is part of the output of svn diff. It is  
not actual text in the file.

I hope... :-)

NB: editors on Windows very often forget the last newline, so I see this  
message a lot at my work.

Ronald.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.xgtnr70mkndu52>