Date: Sun, 6 Sep 1998 11:21:41 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: Mike Haertel <mike@ducky.net> Cc: current@FreeBSD.ORG, wollman@khavrinen.lcs.mit.edu Subject: Re: DANGER: new IP fragment code breaks SLIP Message-ID: <Pine.BSF.4.01.9809061119430.796-100000@herring.nlsystems.com> In-Reply-To: <199809052110.OAA00369@ducky.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 5 Sep 1998, Mike Haertel wrote:
> I've been experiencing crashes with recent 3.0 kernels using SLIP
> based dialin networking. Haven't had time yet to set up kernel
> debugging, however I spent a half an hour doing binary search via
> kernel builds on recent CVS commits. The bug is either contained
> in, or perhaps exposed by, the following commit:
Would it be possible to get a packet trace with tcpdump for one of these
crashes? It would make it easier to deduce the path taken through the
reassembly code. In the mean time could you add this patch to
uipc_socket2.c to test out a possible cause of the crash:
Index: uipc_socket2.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/uipc_socket2.c,v
retrieving revision 1.39
diff -u -r1.39 uipc_socket2.c
--- uipc_socket2.c 1998/09/05 13:24:39 1.39
+++ uipc_socket2.c 1998/09/06 09:35:59
@@ -457,6 +457,8 @@
if (m == 0)
return;
+ if (m->m_nextpkt)
+ panic("sbappend: unexpected packet chain");
n = sb->sb_mb;
if (n) {
while (n->m_nextpkt)
--
Doug Rabson Mail: dfr@nlsystems.com
Nonlinear Systems Ltd. Phone: +44 181 951 1891
Fax: +44 181 381 1039
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9809061119430.796-100000>