Date: Wed, 15 Feb 2023 09:48:42 -0700 From: Warner Losh <imp@bsdimp.com> To: Alan Somers <asomers@freebsd.org> Cc: Emmanuel Vadot <manu@bidouilliste.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7919c76dbdd2 - main - bsdinstall: use gpt/efiboot0 label in /etc/fstab Message-ID: <CANCZdfod9UO4baYh0qAMGBhF6yFJb9JocL_07Wea40RxadKAfw@mail.gmail.com> In-Reply-To: <CAOtMX2hYG342ROszEmMnSCXx6MpR_i06CByd_qX3jHHQC7Z3tQ@mail.gmail.com> References: <202205241917.24OJHipu099732@gitrepo.freebsd.org> <20230215103139.c66c65a80b9be787deaa36a2@bidouilliste.com> <CAOtMX2hYG342ROszEmMnSCXx6MpR_i06CByd_qX3jHHQC7Z3tQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Feb 15, 2023 at 9:35 AM Alan Somers <asomers@freebsd.org> wrote: > On Wed, Feb 15, 2023 at 2:31 AM Emmanuel Vadot <manu@bidouilliste.com> > wrote: > > > > > > Hello Alan, > > > > On Tue, 24 May 2022 19:17:44 GMT > > Alan Somers <asomers@FreeBSD.org> wrote: > > > > > The branch main has been updated by asomers: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=7919c76dbdd20161247d1bfb647110d87ca5ee0f > > > > > > commit 7919c76dbdd20161247d1bfb647110d87ca5ee0f > > > Author: Alan Somers <asomers@FreeBSD.org> > > > AuthorDate: 2022-05-24 18:24:12 +0000 > > > Commit: Alan Somers <asomers@FreeBSD.org> > > > CommitDate: 2022-05-24 19:17:10 +0000 > > > > > > bsdinstall: use gpt/efiboot0 label in /etc/fstab > > > > > > Otherwise, boot will hang if the numbering of disks has changed > since > > > initial install. > > > > > > MFC after: 2 weeks > > > Sponsored by: Axcient > > > Reviewed by: brd > > > Differential Revision: https://reviews.freebsd.org/D35309 > > > > So, I understand the initial problem but this causes a new one. > > efibootmgr is now confused when you ask to print the unix path of the > > ESP because the device resolved is still ada0p1 (for example) and since > > it's not mounted anymore as the label is used we can't discover the > > path to the mounted ESP. > > Since it's now in 13.2 we've just noticed that at work. > > We will parse glabel but it's really horrible to parse and it be good > > to have efibootmgr -E -p working again on a fresh install. > > > > Cheers, > > > > -- > > Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org> > > Annoying. Could you please open a bugzilla PR so we don't lose track of > this? > Yea, when I wrote the code I kinda gave up after needing to walk backwards in the geom mesh for places there were no back pointers. I've left more details on the bug that corvind@ filled. Likely a little brute force is all that's needed to find what we need... Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 15, 2023 at 9:35 AM Alan Somers <<a href="mailto:asomers@freebsd.org">asomers@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Feb 15, 2023 at 2:31 AM Emmanuel Vadot <<a href="mailto:manu@bidouilliste.com" target="_blank">manu@bidouilliste.com</a>> wrote:<br> ><br> ><br> > Hello Alan,<br> ><br> > On Tue, 24 May 2022 19:17:44 GMT<br> > Alan Somers <asomers@FreeBSD.org> wrote:<br> ><br> > > The branch main has been updated by asomers:<br> > ><br> > > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=7919c76dbdd20161247d1bfb647110d87ca5ee0f" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=7919c76dbdd20161247d1bfb647110d87ca5ee0f</a><br>; > ><br> > > commit 7919c76dbdd20161247d1bfb647110d87ca5ee0f<br> > > Author: Alan Somers <asomers@FreeBSD.org><br> > > AuthorDate: 2022-05-24 18:24:12 +0000<br> > > Commit: Alan Somers <asomers@FreeBSD.org><br> > > CommitDate: 2022-05-24 19:17:10 +0000<br> > ><br> > > bsdinstall: use gpt/efiboot0 label in /etc/fstab<br> > ><br> > > Otherwise, boot will hang if the numbering of disks has changed since<br> > > initial install.<br> > ><br> > > MFC after: 2 weeks<br> > > Sponsored by: Axcient<br> > > Reviewed by: brd<br> > > Differential Revision: <a href="https://reviews.freebsd.org/D35309" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D35309</a><br>; ><br> > So, I understand the initial problem but this causes a new one.<br> > efibootmgr is now confused when you ask to print the unix path of the<br> > ESP because the device resolved is still ada0p1 (for example) and since<br> > it's not mounted anymore as the label is used we can't discover the<br> > path to the mounted ESP.<br> > Since it's now in 13.2 we've just noticed that at work.<br> > We will parse glabel but it's really horrible to parse and it be good<br> > to have efibootmgr -E -p working again on a fresh install.<br> ><br> > Cheers,<br> ><br> > --<br> > Emmanuel Vadot <<a href="mailto:manu@bidouilliste.com" target="_blank">manu@bidouilliste.com</a>> <<a href="mailto:manu@freebsd.org" target="_blank">manu@freebsd.org</a>><br> <br> Annoying. Could you please open a bugzilla PR so we don't lose track of this?<br></blockquote><div><br></div><div>Yea, when I wrote the code I kinda gave up after needing to walk backwards in</div><div>the geom mesh for places there were no back pointers. I've left more details on the</div><div>bug that corvind@ filled. Likely a little brute force is all that's needed to find what</div><div>we need...</div><div><br></div><div>Warner</div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfod9UO4baYh0qAMGBhF6yFJb9JocL_07Wea40RxadKAfw>