Date: Fri, 7 Jul 1995 17:00:02 -0700 From: Heikki Suonsivu <hsu@clinet.fi> To: freebsd-bugs Subject: kern/600: PPP does not pay attention to IPTOS_LOWDELAY Message-ID: <199507080000.RAA29882@freefall.cdrom.com> In-Reply-To: Your message of Sat, 8 Jul 1995 02:51:45 %2B0300 <199507072351.CAA15318@katiska.clinet.fi>
index | next in thread | previous in thread | raw e-mail
>Number: 600
>Category: kern
>Synopsis: PPP does not pay attention to IPTOS_LOWDELAY
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs (FreeBSD bugs mailing list)
>State: open
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Jul 7 17:00:01 1995
>Originator: Heikki Suonsivu
>Organization:
Clinet, Espoo, Finland
>Release: FreeBSD 2.0-BUILT-19950507 i386
>Environment:
-current
>Description:
Kernel PPP doesn't pay attention to IPTOS_LOWDELAY, but uses
a table of port numbers, which isn't a generic method. The following
patch fixes this (the table is still used, but in addition
PPP queues the packet in fastq if IPTOS_LOWDELAY is set.
>How-To-Repeat:
Use ports other than standard ones for some purpose and run ftp
simultaneously on a slow link.
>Fix:
This one is from Tatu Ylonen <ylo@cs.hut.fi>
*** if_ppp.c.orig Mon Jun 12 23:47:34 1995
--- if_ppp.c Wed Jul 5 18:12:04 1995
***************
*** 680,685 ****
--- 680,694 ----
if (INTERACTIVE(p & 0xffff) || INTERACTIVE(p >> 16))
ifq = &sc->sc_fastq;
}
+
+ /*
+ * Most high-priority services set IPTOS_LOWDELAY. This is a much more
+ * generic mechanism than specific port numbers. This same mechanism
+ * is used by slip.
+ */
+ if (ip->ip_tos & IPTOS_LOWDELAY)
+ ifq = &sc->sc_fastq;
+
break;
#endif
#ifdef NS
>Audit-Trail:
>Unformatted:
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507080000.RAA29882>