Date: Tue, 12 Sep 2000 19:20:02 -0700 (PDT) From: Gerhard Sittig <Gerhard.Sittig@gmx.net> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/21017: mtree's "no such file" message at job's end Message-ID: <200009130220.TAA99244@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/21017; it has been noted by GNATS.
From: Gerhard Sittig <Gerhard.Sittig@gmx.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Re: bin/21017: mtree's "no such file" message at job's end
Date: Tue, 12 Sep 2000 20:35:31 +0200
On Sat, Sep 09, 2000 at 20:14 +0200, Gerhard Sittig wrote:
>
> -----------------------------------------------------------------
> --- compare.c 2000/06/28 02:33:17 1.15.2.1
> +++ compare.c 2000/09/09 15:20:41
> @@ -298,7 +298,7 @@
>
> }
>
> #endif /* RMD160 */
> - if (s->flags & F_SLINK && strcmp(cp = rlink(name), s->slink)) {
> + if (s->flags & F_SLINK && strcmp(cp = rlink(p->fts_accpath), s->slink)) {
> LABEL;
> (void)printf("%slink ref (%s, %s)\n", tab, cp, s->slink);
> }
> -----------------------------------------------------------------
>
> This patch makes mtree(1) work again. [ ... ]
That's the stage where I thought this PR to be assigned to some
mtree programmer and closed real soon. :) Looking at create.c
(which I wish I had done so a little earlier) will reveal that
this is the real solution to the bug mtree has: it fails to
compare _any_ symlink not living in the -p base directory (or
cwd, however you invoke it). But maybe this patch should not
have been buried the way it was in my previous posting.
That I thought mtree to fail sometimes only seems to be due to me
not realizing how few symlinks are on my filesystems ... And I'm
aware of the fact that I should teach myself some more basic
skills (how do I operate my editor? may I stop proofreading my
emails after recognizing my own sig or is this too much of a
hurry?) before telling others how to fix sbin executables. :>
virtually yours 82D1 9B9C 01DC 4FB4 D7B4 61BE 3F49 4F77 72DE DA76
Gerhard Sittig true | mail -s "get gpg key" Gerhard.Sittig@gmx.net
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009130220.TAA99244>