Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Dec 2010 12:37:18 -0800
From:      Stanislav Sedov <stas@FreeBSD.org>
To:        multimedia@FreeBSD.org
Cc:        ports@FreeBSD.org
Subject:   mpeg4ip compilation error
Message-ID:  <20101209123718.971c1c8e.stas@FreeBSD.org>

next in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Hi!

I'm getting the error trying to compile mpeg4ip:
> getopt.c: In function '_getopt_internal':
> getopt.c:553: warning: passing argument 1 of 'exchange' discards qualifiers from pointer target type
> getopt.c:575: warning: passing argument 1 of 'exchange' discards qualifiers from pointer target type
> gmake[3]: *** [getopt.lo] Error 1
> gmake[3]: Leaving directory `/storage0/obj/ports/usr/ports/multimedia/mpeg4ip/work/mpeg4ip-1.6.1/lib/gnu'
> gmake[2]: *** [all-recursive] Error 1
> gmake[2]: Leaving directory `/storage0/obj/ports/usr/ports/multimedia/mpeg4ip/work/ mpeg4ip-1.6.1/lib'
> gmake[1]: *** [all-recursive] Error 1
> gmake[1]: Leaving directory `/storage0/obj/ports/usr/ports/multimedia/mpeg4ip/work/mpeg4ip-1.6.1'
> gmake: *** [all] Error 2
> *** Error code 1

I discovered that this is due to the fact it tries to compile the getopt library
from GLIBC instead of using the one provided by libc.  The following patch fixes
that.  May I commit?

Thanks!

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/multimedia/mpeg4ip/Makefile,v
retrieving revision 1.98
diff -u -r1.98 Makefile
--- Makefile	30 Nov 2010 09:50:46 -0000	1.98
+++ Makefile	9 Dec 2010 20:34:48 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	mpeg4ip
 PORTVERSION=	1.6.1
-PORTREVISION=	14
+PORTREVISION=	15
 CATEGORIES=	multimedia audio ipv6 net
 MASTER_SITES=	LOCAL/ahze
 # http://sourceforge.net/forum/forum.php?thread_id=1839453&forum_id=59136
Index: files/patch-configure
===================================================================
RCS file: /home/pcvs/ports/multimedia/mpeg4ip/files/patch-configure,v
retrieving revision 1.2
diff -u -r1.2 patch-configure
--- files/patch-configure	19 May 2005 12:42:11 -0000	1.2
+++ files/patch-configure	9 Dec 2010 20:34:48 -0000
@@ -1,6 +1,31 @@
---- configure.orig	Thu May 19 04:55:17 2005
-+++ configure	Thu May 19 04:56:09 2005
-@@ -26062,8 +26062,8 @@
+--- configure.orig	2010-12-09 12:24:43.000000000 -0800
++++ configure	2010-12-09 12:25:28.000000000 -0800
+@@ -24544,13 +24544,12 @@
+ fi
+ 
+ 
+-{ echo "$as_me:$LINENO: checking for getopt_long in -lgnugetopt" >&5
+-echo $ECHO_N "checking for getopt_long in -lgnugetopt... $ECHO_C" >&6; }
++{ echo "$as_me:$LINENO: checking for getopt_long in -lc" >&5
++echo $ECHO_N "checking for getopt_long in -lc... $ECHO_C" >&6; }
+ if test "${ac_cv_lib_gnugetopt_getopt_long+set}" = set; then
+   echo $ECHO_N "(cached) $ECHO_C" >&6
+ else
+   ac_check_lib_save_LIBS=$LIBS
+-LIBS="-lgnugetopt  $LIBS"
+ cat >conftest.$ac_ext <<_ACEOF
+ /* confdefs.h.  */
+ _ACEOF
+@@ -24610,8 +24609,6 @@
+ #define HAVE_LIBGNUGETOPT 1
+ _ACEOF
+ 
+-  LIBS="-lgnugetopt $LIBS"
+-
+ fi
+ 
+ { echo "$as_me:$LINENO: checking for library containing inet_addr" >&5
+@@ -26431,8 +26428,8 @@
    if test x$have_ffmpeg_arg = xtrue; then
       { echo "$as_me:$LINENO: have enable ffmpeg $enable_ffmpeg" >&5
  echo "$as_me: have enable ffmpeg $enable_ffmpeg" >&6;}
@@ -10,4 +35,4 @@
 +     FFMPEG_LIB="${enable_ffmpeg}/lib/libavcodec.a -lz"
       saveCFLAGS="$CFLAGS"
       CFLAGS="$CFLAGS $FFMPEG_INC"
-      echo "$as_me:$LINENO: checking for AVRational" >&5
+      { echo "$as_me:$LINENO: checking for AVRational" >&5
Index: files/patch-mpeg4ip_config.h.in
===================================================================
RCS file: files/patch-mpeg4ip_config.h.in
diff -N files/patch-mpeg4ip_config.h.in
--- files/patch-mpeg4ip_config.h.in	10 Nov 2004 01:02:45 -0000	1.2
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,27 +0,0 @@
---- mpeg4ip_config.h.in.orig	Tue May 18 13:31:06 2004
-+++ mpeg4ip_config.h.in	Wed Sep 29 14:40:59 2004
-@@ -25,16 +25,12 @@
- #undef HAVE_FPOS_T___POS
- 
- /* Define to 1 if you have the `getopt' function. */
--#undef HAVE_GETOPT
- 
- /* Define to 1 if you have the <getopt.h> header file. */
--#undef HAVE_GETOPT_H
- 
- /* Define to 1 if you have the `getopt_long' function. */
--#undef HAVE_GETOPT_LONG
- 
- /* Define to 1 if you have the `getopt_long_only' function. */
--#undef HAVE_GETOPT_LONG_ONLY
- 
- /* Define to 1 if you have the `getrusage' function. */
- #undef HAVE_GETRUSAGE
-@@ -67,7 +63,6 @@
- #undef HAVE_IPv6
- 
- /* Define to 1 if you have the `gnugetopt' library (-lgnugetopt). */
--#undef HAVE_LIBGNUGETOPT
- 
- /* have libmpeg2 decoder library */
- #undef HAVE_LIBMPEG2


-- 
Stanislav Sedov
ST4096-RIPE

()  ascii ribbon campaign - against html e-mail 
/\  www.asciiribbon.org   - against proprietary attachments

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJNAT4FAAoJEL8lojEJL9nwNB0QAKaWOt1NxAuc7U+JNn0j1lME
bkX5nWZQ911Ag8Kk3pF6AX3grO6AbIJdGhdoTJBcGuYlZwceNelJzWamEMIXFdEo
h2bgcSoqk1cd3z8rGu2pdN2I/Tq7kTQXeXA5u6UiruzvEztN6gMWygKPbrz/nCQE
04xGq4cY8EtKXK99GLLtq5yzrEUBLj9qBpHaPlen9p4Xg5ZEOmdIni7aBhrOHLOK
2AkmtQLq0plT1b/KnGkZjxWvLdw1DEVy3Qd5MHDS7Gt2Dd8wqSlDyhht4mOaoRXD
89Bg1ZlGJgQTuM2MsvkRc6DbhodssT48q3ZoU3v75e1eQb9WGactpCKV4UJ4ZFrZ
pe03mg23pLtBygVjP5j8jRXfwqSduDgQZS9TSUDtC8ttbh1DPgKJIn2wrmo1LQKI
x774PuT7nv6Ora6gfblvKXZQEj4weFVnB8wF1hwTZf04ACDHN+gKMK/FOD00RMmq
MMOU6rYphf+K1hNyoyFQYwp7QYZu5nhI1q7p5OorsLgV2Jsfaq6vnG8kP3QEskc2
FupHpOzu3q+PJ6p/cCN2NW0fMez2UCDY70nxEk3Rg6x3ARRktCebmk2CKhpz6FPT
09M3ZvUbEFdoSjdprCwUBNLLQih4DLLUuGOV6Ni4izQxAtRXHizIWQGGGDXKCaKw
c8WY8HGg3gE8k/mUlLkt
=W7fO
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101209123718.971c1c8e.stas>