Date: Sat, 20 Apr 2019 14:35:03 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 233319] net-mgmt/unbound_exporter: Update port to latest commit of unbound_exporter Message-ID: <bug-233319-7788-LI7YsSSRZ0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233319-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-233319-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233319 --- Comment #11 from Kubilay Kocak <koobs@FreeBSD.org> --- Aside from confirmation of QA (portlint / poudriere), it's likely to be just waiting for someone with Go/golang experience to review/test before committ= ing. FWIW, the patch as supplied doesn't apply as is. Having said that, ive made= the changes to the port manually, and will run through QA. If it passes I'll co= mmit it as is. For example, as is, the port fails portlint with: =3D=3D=3D> Validating port with portlint WARN: Makefile: [39]: possible direct use of command "echo" found. use ${ECHO_CMD} or ${ECHO_MSG} instead. FATAL: Makefile: DISTVERSIONPREFIX appears out-of-order. FATAL: Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTRE= VISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKG= NAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRAC= T_ONLY. 2 fatal errors and 1 warning found. For future issues, it's really important as a maintainer to run a port thro= ugh as much QA as possible, at the very least portlint and poudriere, and confi= rm that the port passes QA when submitting the changes. Doing so picks up many issues before submission that can prevent an issue from progressing quickly. Also, regarding the PORTVERSION, it would be great to see upstream start to= use Git tags to tag proper version numbers (x.y.z), so that this port can use t= hose tags, instead of git tags directly to fetch the code, and reference in PORTVERSION --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233319-7788-LI7YsSSRZ0>