Date: Mon, 28 Jun 2021 15:16:18 -0700 From: Kyle Evans <kevans@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 175841285e28 - main - Add deprecation notice for WITH_PROFILE option Message-ID: <CACNAnaHOkHTiqafOx%2BZk5HArdNkXLsDwHmVsUg_8sMSW-4MzCA@mail.gmail.com> In-Reply-To: <CAPyFy2AbMG30tAh7KXC15eVwzGwNTPjLnywzsHJ35P4vxTFg4A@mail.gmail.com> References: <202106281537.15SFbdiG002780@gitrepo.freebsd.org> <CACNAnaFZe_bKAtrSzaMzJzV5F8Q3K1F1tVEAncLT9u=mEtwuiA@mail.gmail.com> <CAPyFy2CEp8r1zR%2BJL48a-0GXGP3g_kqwQ4AOWu1oPu3y-Ty16Q@mail.gmail.com> <CACNAnaHFiYR6_a0Ffu9avxLdJze47vJcwD56E5cUJb-474LOSQ@mail.gmail.com> <CAPyFy2AbMG30tAh7KXC15eVwzGwNTPjLnywzsHJ35P4vxTFg4A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 28, 2021 at 2:43 PM Ed Maste <emaste@freebsd.org> wrote: > > On Mon, 28 Jun 2021 at 16:01, Kyle Evans <kevans@freebsd.org> wrote: > > > > On Mon, Jun 28, 2021 at 12:57 PM Ed Maste <emaste@freebsd.org> wrote: > > > > > > How about "The PROFILE functionality is not available in .Fx 14."? > > > > +1, I like that. > > Hrm, I think I don't need a note in WITHOUT_PROFILE in fact. I added > it originally because I thought PROFILE was on by default for all > archs on stable branches, which would have only WITHOUT_PROFILE in > src.conf.5. However, mips64 lacks PROFILE support so both are listed - > thus with a note in WITH_PROFILE only we'd have: > > WITHOUT_PROFILE > Do not build profiled libraries for use with gprof(8). > > This is a default setting on mips/mips64. > > WITH_PROFILE > Build profiled libraries for use with gprof(8). This option is > deprecated and is not present in FreeBSD 14. > > This is a default setting on amd64/amd64, arm/armv6, arm/armv7, > arm64/aarch64, i386/i386, mips/mips, powerpc/powerpc, > powerpc/powerpc64, riscv/riscv64 and riscv/riscv64sf. > > which I think is sufficient. Oh yeah, totally; +1 to omitting it based on this.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHOkHTiqafOx%2BZk5HArdNkXLsDwHmVsUg_8sMSW-4MzCA>