Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 May 2012 10:02:42 +0000 (UTC)
From:      Edward Tomasz Napierala <trasz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r235890 - stable/9/sys/kern
Message-ID:  <201205241002.q4OA2gOf029180@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: trasz
Date: Thu May 24 10:02:42 2012
New Revision: 235890
URL: http://svn.freebsd.org/changeset/base/235890

Log:
  MFC r234385:
  
  Fix bug where NFSv4 ACL enforcement code wouldn't unconditionally
  allow the owner to read and write ACL and file attributes when there
  was no entry with subject matching the owner.  In other words,
  'getfacl meh' shouldn't fail for the owner if the ACL looks like this:
  
  # file: meh
  # owner: trasz
  # group: wheel
           user:root:------a-------:------:allow

Modified:
  stable/9/sys/kern/subr_acl_nfs4.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/kern/subr_acl_nfs4.c
==============================================================================
--- stable/9/sys/kern/subr_acl_nfs4.c	Thu May 24 09:59:58 2012	(r235889)
+++ stable/9/sys/kern/subr_acl_nfs4.c	Thu May 24 10:02:42 2012	(r235890)
@@ -160,6 +160,9 @@ _acl_denies(const struct acl *aclp, int 
 			return (0);
 	}
 
+	if (access_mask == 0)
+		return (0);
+
 	return (1);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205241002.q4OA2gOf029180>