Date: Sat, 20 Aug 2016 20:06:07 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 203204] [NEW PORT] databases/pgmodeler: PostgreSQL Database Modeler Message-ID: <bug-203204-13-3NBGO7XzpP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-203204-13@https.bugs.freebsd.org/bugzilla/> References: <bug-203204-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203204 Raphael Kubo da Costa <rakuco@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Open |In Progress --- Comment #8 from Raphael Kubo da Costa <rakuco@FreeBSD.org> --- Hi there, Sorry for the absence. I've finally taken a look at the latest patch (0.8.2) and only have some comments with things that should be improved before land= ing: - You don't need both USES=3Dqmake and USE_QT5=3Dqmake_build; USES=3Dqmake = is enough. - GH_ACCOUNT=3Dpgmodeler is redundant; the ports framework uses ${PORTNAME}= by default. - You should just use "lib" instead of the occurrences of "%%QT_LIBDIR%%" in pkg-plist. The latter should be used only by the Qt ports themselves in general. Thanks for the work; again, I apologize for taking so long to review the pa= tch, at least we're really close now! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-203204-13-3NBGO7XzpP>