Date: Tue, 4 Jun 2002 09:25:47 -0700 From: Luigi Rizzo <rizzo@icir.org> To: Lars Eggert <larse@ISI.EDU> Cc: net@FreeBSD.ORG Subject: Re: Dummynet WFQ Message-ID: <20020604092547.B88852@iguana.icir.org> In-Reply-To: <3CFCE935.8090603@isi.edu>; from larse@ISI.EDU on Tue, Jun 04, 2002 at 09:22:13AM -0700 References: <3CFB9BC4.9080506@isi.edu> <20020603122913.A78688@iguana.icir.org> <3CFCE101.3040108@isi.edu> <3CFCE1CF.2070001@isi.edu> <20020604090719.A88701@iguana.icir.org> <3CFCE935.8090603@isi.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 04, 2002 at 09:22:13AM -0700, Lars Eggert wrote: > Luigi Rizzo wrote: > > BTW if you use polling, you have to be careful in the place where you > > put the call to if_tx_rdy() to make sure that it catches the tx queue > > becoming empty only once and not at every polling cycle. > > How about at the very end of sis_intr(), as a new "else" branch of the > queue length check, like this: except that sis_intr is never called when you use polling :( cheers luigi > if (ifp->if_snd.ifq_head != NULL) > sis_start(ifp); > + > else > + > if_tx_ready(ifp); > > That doesn't seem to be in the codepath that gets executed on each poll, > right? > > > p.s. the soekris boxes are becoming popular, aren't they! > > They are amazing, I'm really glad the folks on freebsd-small have > pointed us at them. Only downside is that you go blind if you look at > the case for too long :-) > > Lars > -- > Lars Eggert <larse@isi.edu> USC Information Sciences Institute To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020604092547.B88852>