Date: Tue, 28 Mar 2006 17:29:32 +0800 From: David Xu <davidxu@freebsd.org> To: Dag-Erling Smorgrav <des@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern syscalls.master src/sys/sys sysproto.h umtx.h Message-ID: <442901FC.6010008@freebsd.org> In-Reply-To: <200603280918.k2S9IZM5008601@repoman.freebsd.org> References: <200603280918.k2S9IZM5008601@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smorgrav wrote: > des 2006-03-28 09:18:34 UTC > > FreeBSD src repository > > Modified files: > sys/kern syscalls.master > sys/sys sysproto.h umtx.h > Log: > The undocumented and deprecated system call _umtx_op() takes two pointer > arguments. The first one is never used (all callers pass in 0); the > second is sometimes used to pass in a struct timespec * which is used as > a timeout and never modified. Constify that argument so callers can pass > a const struct timespec * without jumping through hoops. > > Revision Changes Path > 1.214 +1 -1 src/sys/kern/syscalls.master > 1.193 +1 -1 src/sys/sys/sysproto.h > 1.18 +3 -3 src/sys/sys/umtx.h > > This is an incorrect change, please backout it. the _umtx_op parameters never should only accept const void *, in fact, the interface was designed to extendable for future use. you can use __DECONST macro in umtx.h to disable compiler warnings, breaking it could cause FreeBSD to not have optimized thread library can be used.next when you want to change umtx code, please discuss with me first. Regards, David Xu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?442901FC.6010008>