Date: Sun, 09 Aug 2026 17:01:43 +0000 From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih <freebsd@seuros.com> Subject: git: a8165edb50ab - main - fwcam: release the IR DMA channel when starting the stream fails Message-ID: <6a78b277.399dc.22a42952@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=a8165edb50ab323241fa622f720d724bc5f22150 commit a8165edb50ab323241fa622f720d724bc5f22150 Author: Abdelkader Boudih <freebsd@seuros.com> AuthorDate: 2026-08-09 16:59:26 +0000 Commit: Adrian Chadd <adrian@FreeBSD.org> CommitDate: 2026-08-09 16:59:29 +0000 fwcam: release the IR DMA channel when starting the stream fails Disabled the IR DMA channel on the error path, which clears the flag and frees the descriptor blocks before the chunks go away. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D58502 --- sys/dev/firewire/fwcam.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/firewire/fwcam.c b/sys/dev/firewire/fwcam.c index c98eb7a9894c..e2b53935597b 100644 --- a/sys/dev/firewire/fwcam.c +++ b/sys/dev/firewire/fwcam.c @@ -534,6 +534,9 @@ fwcam_iso_start(struct fwcam_softc *sc) return (0); fail: + if (xferq->flag & FWXFERQ_RUNNING) + fc->irx_disable(fc, dma_ch); + fw_iso_free_chunks(xferq, M_FWCAM); xferq->flag &= ~(FWXFERQ_MODEMASK | FWXFERQ_OPEN | FWXFERQ_STREAM | FWXFERQ_EXTBUF | FWXFERQ_HANDLER | FWXFERQ_CHTAGMASK);home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a78b277.399dc.22a42952>