Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Dec 2013 22:58:58 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r259362 - in head: etc sbin/devd
Message-ID:  <201312132258.rBDMwwI3063198@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers
Date: Fri Dec 13 22:58:57 2013
New Revision: 259362
URL: http://svnweb.freebsd.org/changeset/base/259362

Log:
  sbin/devd/devd.cc
  	Promoting the SIGINFO handler's log message from LOG_INFO to
  	LOG_NOTICE, and promoting the "Processing event ..." message from
  	LOG_DEBUG to LOG_INFO.  Setting the logfile to LOG_NOTICE with this
  	change will have the same result as setting it to LOG_INFO without
  	this change.  Setting it to LOG_INFO with this change will include
  	the useful "Processing event ..." messages that were previously at
  	LOG_DEBUG, without including useless messages like "Pushing table".
  
  	The intent of this change is that one can log "Processing event ..."
  	without logging "Pushing table" and related messages that are sent
  	for every event.  The number of lines actually logged is reduced by
  	about 75% by making this change and setting syslog to LOG_INFO vs
  	setting syslog to LOG_DEBUG.
  
  etc/syslog.conf
  	Changing the recommended loglevel to notice instead of info.
  
  Sponsored by:	Spectra Logic Corp
  MFC after:	4 weeks

Modified:
  head/etc/syslog.conf
  head/sbin/devd/devd.cc

Modified: head/etc/syslog.conf
==============================================================================
--- head/etc/syslog.conf	Fri Dec 13 22:52:59 2013	(r259361)
+++ head/etc/syslog.conf	Fri Dec 13 22:58:57 2013	(r259362)
@@ -30,7 +30,7 @@ cron.*						/var/log/cron
 # news.notice					/var/log/news/news.notice
 # Uncomment this if you wish to see messages produced by devd
 # !devd
-# *.>=info                                       /var/log/devd.log
+# *.>=notice					/var/log/devd.log
 !ppp
 *.*						/var/log/ppp.log
 !*

Modified: head/sbin/devd/devd.cc
==============================================================================
--- head/sbin/devd/devd.cc	Fri Dec 13 22:52:59 2013	(r259361)
+++ head/sbin/devd/devd.cc	Fri Dec 13 22:58:57 2013	(r259362)
@@ -772,7 +772,7 @@ process_event(char *buffer)
 	char *sp;
 
 	sp = buffer + 1;
-	devdlog(LOG_DEBUG, "Processing event '%s'\n", buffer);
+	devdlog(LOG_INFO, "Processing event '%s'\n", buffer);
 	type = *buffer++;
 	cfg.push_var_table();
 	// No match doesn't have a device, and the format is a little
@@ -989,7 +989,7 @@ event_loop(void)
 		}
 		rv = select(max_fd, &fds, NULL, NULL, &tv);
 		if (got_siginfo) {
-			devdlog(LOG_INFO, "Events received so far=%u\n",
+			devdlog(LOG_NOTICE, "Events received so far=%u\n",
 			    total_events);
 			got_siginfo = 0;
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312132258.rBDMwwI3063198>