Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Jul 2026 16:07:26 +0000
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: fa2ad70a4511 - main - tcp: make ghost ACK handling more conformant
Message-ID:  <6a623c3e.39fbe.511f46ed@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=fa2ad70a4511e7b379e81de82c9e51b2e0994295

commit fa2ad70a4511e7b379e81de82c9e51b2e0994295
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2026-07-23 16:03:39 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2026-07-23 16:03:39 +0000

    tcp: make ghost ACK handling more conformant
    
    The latest version of draft-ietf-tcpm-tcp-ghost-acks changed
    a condition. This should make no substantial difference, but makei
    it compliant to the latest version of the specification.
    
    Reviewed by:            rscheff, Peter Lei
    MFC after:              3 days
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D58411
---
 sys/netinet/tcp_input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index 2a778687faf2..37706343d621 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -2386,7 +2386,7 @@ tcp_do_segment(struct tcpcb *tp, struct mbuf *m, struct tcphdr *th,
 	/*
 	 * Ack processing.
 	 */
-	if (SEQ_GEQ(tp->snd_una, tp->iss + (TCP_MAXWIN << tp->snd_scale))) {
+	if (SEQ_GT(tp->snd_una, tp->iss + (TCP_MAXWIN << tp->snd_scale))) {
 		/* Checking SEG.ACK against ISS is definitely redundant. */
 		tp->t_flags2 |= TF2_NO_ISS_CHECK;
 	}


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a623c3e.39fbe.511f46ed>