Date: Mon, 2 Jun 2014 11:42:10 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Marcel Moolenaar <marcel@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net Message-ID: <DA4CB2BA-A551-47A4-9E44-766FA29E2EF2@xcllnt.net> In-Reply-To: <CAJ-VmonDJCLYWBPiz1ntFRm8aj4WQd5iHMKK0Wm3hcdjZmxghw@mail.gmail.com> References: <201406021754.s52Hsd1B039620@svn.freebsd.org> <CAJ-VmonRqXrzrqQys_9s7-o8DFmOE_c_BZWupezm0i%2BW7E09vA@mail.gmail.com> <CAJ-VmonDJCLYWBPiz1ntFRm8aj4WQd5iHMKK0Wm3hcdjZmxghw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_25E40353-5F73-4341-A22C-3B49585DABC3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Jun 2, 2014, at 11:27 AM, Adrian Chadd <adrian@freebsd.org> wrote: > .. and actually, bikeshedding for a moment, would we be able to move a > lot of these accessor methods over to inlines? Would that break the > Juniper way of doing things? That would definitely break Juniper as it doesn't give a stable ABI. I've suggested an approach that allows for both, but it was deemed unnecessary. The argument being that the function call overhead is negligible. We can always revisit that decision if needed... -- Marcel Moolenaar marcel@xcllnt.net --Apple-Mail=_25E40353-5F73-4341-A22C-3B49585DABC3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlOMxYIACgkQpgWlLWHuifYNZwCgh5CbW/ZPwAnW7zIjoonnku8i lN4AoIih2kbiZMZj6p02wpQfegIUOses =K8Dy -----END PGP SIGNATURE----- --Apple-Mail=_25E40353-5F73-4341-A22C-3B49585DABC3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DA4CB2BA-A551-47A4-9E44-766FA29E2EF2>