Date: Sat, 26 Jan 2002 12:52:56 +0000 From: David Malone <dwmalone@maths.tcd.ie> To: Julian Elischer <julian@elischer.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm.h Message-ID: <200201261252.aa17054@salmon.maths.tcd.ie> In-Reply-To: Your message of "Fri, 25 Jan 2002 16:30:32 PST." <Pine.BSF.4.21.0201251629410.34033-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> In the kernel it is usual to have parameter names in prototypes > (it was in style) It tends to keep people using standard names for certain > things... OK, but I think something in userland sees this declaration and gcc whines about it. I might have made the change originally when I was playing with WARNS and gcc3. Should this declaration be protected by a #ifdef _KERNEL? I can go an dig up what produced the warning if you think that I would be better fixing it some other way. (Also, the parameter name was "kmi" and the line before in vm.h says "extern struct kva_md_info kmi;", so the parameter would always be shadowing a global variable. I guess that wouldn't have been ideal.) David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <200201261252.aa17054>