Date: Mon, 16 Feb 2009 07:35:19 -0800 From: Andrew Thompson <thompsa@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: usb@FreeBSD.org, weongyo@FreeBSD.org, Hans Petter Selasky <hselasky@freebsd.org> Subject: Re: USB support in NDIS -- IFF_NEEDSGIANT? Message-ID: <20090216153519.GB4723@citylink.fud.org.nz> In-Reply-To: <alpine.BSF.2.00.0902161129060.5806@fledge.watson.org> References: <alpine.BSF.2.00.0902161129060.5806@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 16, 2009 at 11:33:18AM +0000, Robert Watson wrote: > > Dear all: > > As you know, I've been gradually working to eliminate all non-MPSAFE > network device driver infrastructure for 8.0, having removed non-MPSAFE > network protocol infrastructure in 7.0. In reviewing remaining drivers > using IFF_NEEDSGIANT, I spotted this in the NDIS code: > > 718 if_initname(ifp, device_get_name(dev), device_get_unit(dev)); > 719 ifp->if_mtu = ETHERMTU; > 720 ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; > 721 if (sc->ndis_iftype == PNPBus) > 722 ifp->if_flags |= IFF_NEEDSGIANT; > 723 ifp->if_ioctl = ndis_ioctl; > 724 ifp->if_start = ndis_start; > 725 ifp->if_init = ndis_init; > > Having taken a glance, it looks like this was added specifically to support > USB devices attached via NDIS. With the new USB code, are NDIS drivers > still supported? And in the new world order, is this IFF_NEEDSGIANT still > required? Can I simply remove it once the old USB code is on the way out > the door? I had promised Weongyo that I would convert ndis to USB2 but have been a bit busy. Anyone else welcome to pick this up in the mean time. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090216153519.GB4723>