Date: Wed, 16 May 2001 21:47:10 -0700 (PDT) From: Matt Dillon <dillon@earth.backplane.com> To: "Brian F. Feldman" <green@FreeBSD.ORG> Cc: Alfred Perlstein <bright@rush.net>, freebsd-arch@FreeBSD.ORG Subject: Re: Upgrading u_short cr_ref to u_int cr_ref in ucred on -stable Message-ID: <200105170447.f4H4lA188014@earth.backplane.com> References: <200105170442.f4H4gZf51783@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:> a little later I will throw an overflow check and panic into -current
:> (and -stable in 3 days) as per Terry's suggestion.
:
:It would really be a good idea to do it instead of breaking the API
:completely, I think. I've been meaning to test it all on 4.3 and commit it,
:but I'm still finishing school. Finals time means too much worry and not
:enough FreeBSD hacking :( It should be an easy change, though.
:
:--
: Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! /
Well, I agree on principle, but I don't think the changes to cr_ref
breaks any existing programs (though obviously I can't be 100% sure).
A much bigger problem is going to be Tor's O_DIRECT stuff... that
requires the struct file's f_flag to go from short -> u_int. So far
I haven't found anything that breaks. If it turns out to be an issue
I can split the flags field into two shorts (there are unused shorts
elsewhere in the structure).
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105170447.f4H4lA188014>