Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 26 May 2016 18:57:26 +0000 (UTC)
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r300771 - head/sys/netgraph/netflow
Message-ID:  <201605261857.u4QIvQpN074167@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: jkim
Date: Thu May 26 18:57:26 2016
New Revision: 300771
URL: https://svnweb.freebsd.org/changeset/base/300771

Log:
  Use bit_count(3) instead of four bitcount32() calls.
  
  Reviewed by:	asomers, ngie
  Differential Revision:	https://reviews.freebsd.org/D6543

Modified:
  head/sys/netgraph/netflow/netflow.c

Modified: head/sys/netgraph/netflow/netflow.c
==============================================================================
--- head/sys/netgraph/netflow/netflow.c	Thu May 26 18:52:49 2016	(r300770)
+++ head/sys/netgraph/netflow/netflow.c	Thu May 26 18:57:26 2016	(r300771)
@@ -34,6 +34,7 @@ __FBSDID("$FreeBSD$");
 #include "opt_inet6.h"
 #include "opt_route.h"
 #include <sys/param.h>
+#include <sys/bitstring.h>
 #include <sys/systm.h>
 #include <sys/counter.h>
 #include <sys/kernel.h>
@@ -147,6 +148,19 @@ ip6_hash(struct flow6_rec *r)
 		    r->dst.r_dst6.__u6_addr.__u6_addr32[3]);
  	}
 }
+
+static inline int
+ip6_masklen(struct in6_addr *saddr, struct rt_addrinfo *info)
+{
+	const int nbits = sizeof(*saddr) * NBBY;
+	int mlen;
+
+	if (info->rti_addrs & RTA_NETMASK)
+		bit_count((bitstr_t *)saddr, 0, nbits, &mlen);
+	else
+		mlen = nbits;
+	return (mlen);
+}
 #endif
 
 /*
@@ -399,11 +413,6 @@ hash_insert(priv_p priv, struct flow_has
 }
 
 #ifdef INET6
-/* XXX: make normal function, instead of.. */
-#define ipv6_masklen(x)		bitcount32((x).__u6_addr.__u6_addr32[0]) + \
-				bitcount32((x).__u6_addr.__u6_addr32[1]) + \
-				bitcount32((x).__u6_addr.__u6_addr32[2]) + \
-				bitcount32((x).__u6_addr.__u6_addr32[3])
 static int
 hash6_insert(priv_p priv, struct flow_hash_entry *hsh6, struct flow6_rec *r,
 	int plen, uint8_t flags, uint8_t tcp_flags)
@@ -460,11 +469,7 @@ hash6_insert(priv_p priv, struct flow_ha
 				fle6->f.n.next_hop6 =
 				    ((struct sockaddr_in6 *)&rt_gateway)->sin6_addr;
 
-			if (info.rti_addrs & RTA_NETMASK)
-				fle6->f.dst_mask =
-				    ipv6_masklen(sin6_mask.sin6_addr);
-			else
-				fle6->f.dst_mask = 128;
+			fle6->f.dst_mask = ip6_masklen(&sin6_mask.sin6_addr, &info);
 
 			rib_free_info(&info);
 		}
@@ -483,13 +488,8 @@ hash6_insert(priv_p priv, struct flow_ha
 		info.rti_info[RTAX_NETMASK] = (struct sockaddr *)&sin6_mask;
 
 		if (rib_lookup_info(r->fib, (struct sockaddr *)&sin6, 0, 0,
-		    &info) == 0) {
-			if (info.rti_addrs & RTA_NETMASK)
-				fle6->f.src_mask =
-				    ipv6_masklen(sin6_mask.sin6_addr);
-			else
-				fle6->f.src_mask = 128;
-		}
+		    &info) == 0)
+			fle6->f.src_mask = ip6_masklen(&sin6_mask.sin6_addr, &info);
 	}
 
 	/* Push new flow at the and of hash. */
@@ -497,7 +497,6 @@ hash6_insert(priv_p priv, struct flow_ha
 
 	return (0);
 }
-#undef ipv6_masklen
 #endif

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605261857.u4QIvQpN074167>