Date: Fri, 4 Jul 2025 19:19:19 GMT From: Alan Somers <asomers@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: bc3338985af9 - main - sockstat: microoptimize cap-getnameinfo Message-ID: <202507041919.564JJJ0o065467@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=bc3338985af92914a9b6929c631551a527049acf commit bc3338985af92914a9b6929c631551a527049acf Author: Alan Somers <asomers@FreeBSD.org> AuthorDate: 2025-07-03 21:41:47 +0000 Commit: Alan Somers <asomers@FreeBSD.org> CommitDate: 2025-07-04 19:18:34 +0000 sockstat: microoptimize cap-getnameinfo Revert a change to the cap_getnameinfo, accidentally introduced in 0726c6574f8, that caused cap_getnameinfo to populate a buffer which was about to be thrown away. Fixes: 0726c6574f889507e5030173bf4c82c80911394d Sponsored by: ConnectWise Reviewed by: Damin Rido <rido@FreeBSD.org> Pull Request: https://github.com/freebsd/freebsd-src/pull/1753 --- usr.bin/sockstat/sockstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.bin/sockstat/sockstat.c b/usr.bin/sockstat/sockstat.c index 52243910a31c..1a24ff67c321 100644 --- a/usr.bin/sockstat/sockstat.c +++ b/usr.bin/sockstat/sockstat.c @@ -951,7 +951,7 @@ formataddr(struct sockaddr_storage *ss, char *buf, size_t bufsize) } if (addrstr[0] == '\0') { error = cap_getnameinfo(capnet, sstosa(ss), ss->ss_len, - addrstr, sizeof(addrstr), buf, bufsize, NI_NUMERICHOST); + addrstr, sizeof(addrstr), NULL, 0, NI_NUMERICHOST); if (error) errx(1, "cap_getnameinfo()"); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202507041919.564JJJ0o065467>