Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Jun 2020 01:02:06 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Matt Macy <mmacy@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r362667 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace
Message-ID:  <20200627010206.GA63841@FreeBSD.org>
In-Reply-To: <202006270057.05R0vmgC070914@repo.freebsd.org>
References:  <202006270057.05R0vmgC070914@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 27, 2020 at 12:57:48AM +0000, Matt Macy wrote:
> New Revision: 362667
> URL: https://svnweb.freebsd.org/changeset/base/362667
> 
> Log:
>   Fix "current" variable name conflict with openzfs
>   
>   The variable "current" is an alias for curthread
>   in openzfs. Rename all variable uses of current
>   in dtrace.c to curstate.

Shouldn't OpenZFS be fixed instead?  The fact that we need to fix our
local variables suggests that they're abusing too generic name...

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200627010206.GA63841>