Date: Tue, 18 Aug 2009 20:20:15 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/mii e1000phy.c Message-ID: <200908182020.n7IKKP25007926@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
yongari 2009-08-18 20:20:15 UTC
FreeBSD src repository
Modified files:
sys/dev/mii e1000phy.c
Log:
SVN rev 196366 on 2009-08-18 20:20:15Z by yongari
Backout r193289. r193289 restored page select bits to previous
value instead of blindly resetting it to 0. However, it seems page
select bits of some 88E1116 PHY is initialized to invalid one such
that restoring page select bits after programming broke MII
register access. The correct solution would be reset page select
bits to 0 in PHY attach stage but it would require more testing.
Since we're in BETA stage such a change would be dangerous so just
back it out.
This change should fix nfe(4) breakage on NVIDIA MCP55.
Reported by: Ryan Rogers < webmaster <> doghouserepair dot com >
Sam Fourman Jr. < sfourman <> gmail dot com >
Tested by: Ryan Rogers < webmaster <> doghouserepair dot com >
Sam Fourman Jr. < sfourman <> gmail dot com >
Approved by: re (kib)
Revision Changes Path
1.31 +1 -3 src/sys/dev/mii/e1000phy.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908182020.n7IKKP25007926>