Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Aug 2010 20:11:09 +0200
From:      David Demelier <demelier.david@gmail.com>
To:        freebsd-ports@freebsd.org
Subject:   Legal music and sound issues with games/viruskiller
Message-ID:  <4C755CBD.9070801@gmail.com>

next in thread | raw e-mail | index | archive | help
Hi,

We rewrote the games/viruskiller with one option, MUSIC. The musics and 
sounds have legal issues and that is specified here :

http://www.happypenguin.org/forums/viewtopic.php?t=4725

Because I wanted to write this port, I made this option to interact with 
the user. He needs to enable the option to use the sounds and musics.

I also said in the comment options that the files are non-free, then the 
user is completely warned.

Do you agree with this Makefile now ?

--- Makefile.orig	2010-08-25 19:20:40.000000000 +0200
+++ Makefile	2010-08-25 20:06:48.000000000 +0200
@@ -20,15 +20,26 @@
  USE_SDL=	mixer image ttf net
  USE_GMAKE=	yes

+NO_CDROM=	yes
+
  INSTALLS_ICONS=	yes

  WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}

  MAKEFILE=	makefile

+OPTIONS=	MUSIC "Enable musics (non-free)" Off
+
+.include <bsd.port.options.mk>
+
+.if !defined(WITH_MUSIC)
+SUB_FILES=	pkg-message
+.endif
+
  post-patch:
-	# Remove non-free restricted files:
-	${RM} -f ${WRKSRC}/music/* ${WRKSRC}/sound/*
+.if !defined(WITH_MUSIC)
+	@${REINPLACE_CMD} -e "s|music||g;s|sound||g" ${WRKSRC}/makefile
+.endif

  .if defined(NOPORTDOCS)
  	@${REINPLACE_CMD} -e "s|^.*install.*DOCS.*||g" \
@@ -40,4 +51,9 @@
  		-e "s|^DATADIR.*|DATADIR=${DATADIR}/|g" \
  		-e "s|^DOCDIR.*|DOCDIR=${DOCSDIR}|g" ${WRKSRC}/makefile

+post-install:
+.if !defined(WITH_MUSIC)
+	@${CAT} ${PKGMESSAGE}
+.endif
+
  .include <bsd.port.mk>
--- /dev/null	2010-08-25 20:08:43.000000000 +0200
+++ files/pkg-message.in	2010-08-25 20:05:20.000000000 +0200
@@ -0,0 +1,2 @@
+Because you disabled music you need to start viruskiller with the 
-noaudio flag,
+otherwise it will segfaults.

I think with this, we could keep the game in the ports/ tree.

With kind regards.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C755CBD.9070801>