Date: Thu, 5 Dec 2019 11:40:07 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Ian Lepore <ian@freebsd.org> Cc: rgrimes@freebsd.org, John Baldwin <jhb@freebsd.org>, Vincenzo Maffione <vmaffione@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355301 - head/usr.sbin/bhyve Message-ID: <201912051940.xB5Je7xW045499@gndrsh.dnsmgr.net> In-Reply-To: <b334de119b68776d4a816eb904dbb558f69dfa7c.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, 2019-12-05 at 11:21 -0800, Rodney W. Grimes wrote: > > > On 12/4/19 9:35 PM, Rodney W. Grimes wrote: > > > > > I see, thanks for the pointers. > > > > > It looks like cfmakeraw() and tcsetattr() were what I was > > > > > looking for. > > > > > A bhyve-specific printf wrapper looks the right solution to me. > > > > > I can try to sketch a patch for you guys to review, if that's > > > > > useful. > > > > > > > > > > Cheers, > > > > > Vincenzo > > > > > > > > Meanwhile could you please revert the commit, and add a note to > > > > D22552 to the effects that this was not the right solution? > > > > > > I don't think we have to revert as it isn't that big of a > > > deal. Just > > > fixing it going forward is probably fine. > > > > I disagree. Not reverting this leads to a bunch of un-needed changes > > in the forward moving review, clouding the view of what is really > > being changed in that new review which is now a mix of undoing this > > and adding a new set of macros to deal with end of line. > > > > It doesn't cloud anything in the new review. Reverting it will change > all the \n\r back to just \n. Then exactly the same lines will need > changing on the do-over to remove the \n. ACK Ok, my oversight, I thought the \n would be staying, but your right it goes too. > There are times when backing out a changeset and doing things over from > scratch make sense, but this doesn't seem to be one of them. Perhaps... but fundementally, IMHO, a wrong change should just be reverted even if the fix is simple and soon. Again, IMHO, we are far to shy about using revert. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912051940.xB5Je7xW045499>