Date: Fri, 26 Apr 2024 00:19:44 +0200 From: =?utf-8?Q?Klaus_K=C3=BCchemann?= <maciphone2@googlemail.com> To: Kyle Evans <kevans@FreeBSD.org>, Warner Losh <imp@bsdimp.com>, cperciva@tarsnap.com, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, hp@tmm.cx Subject: Re: git: 1bd4f769caf8 - main - add dtb support for RPI CM4, CM4s, CM4_ioBoard Message-ID: <F4317843-3597-4675-A576-664955166762@googlemail.com> In-Reply-To: <142362e6-8a88-43f5-bff6-6ff90a12802e@FreeBSD.org> References: <202404192311.43JNBiVS059729@gitrepo.freebsd.org> <0100018f169ec80a-47d419c2-2cd6-4ee1-89da-3f4782429089-000000@email.amazonses.com> <CANCZdfp0S4bqAMjj1HQt3gHwr56T%2B_tyo7w1xi5GG1pXPWAOzA@mail.gmail.com> <0100018f16c8f23a-eacbe781-3f6e-4f02-9b4d-d26468364b1f-000000@email.amazonses.com> <7473b5ed-433b-4d51-8a23-cf6464eb4416@FreeBSD.org> <7FA67865-F391-4773-86BA-9998B3EC855E@googlemail.com> <142362e6-8a88-43f5-bff6-6ff90a12802e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_1E6194A7-523A-4EAA-80C9-840CB6271984 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Am 26.04.2024 um 00:09 schrieb Kyle Evans <kevans@FreeBSD.org>: >=20 > On 4/25/24 16:44, Klaus K=C3=BCchemann wrote: >>> Am 25.04.2024 um 22:01 schrieb Kyle Evans <kevans@FreeBSD.org>: >>>=20 >>> On 4/25/24 14:43, Colin Percival wrote: >>>> On 4/25/24 12:24, Warner Losh wrote: >>>>> On Thu, Apr 25, 2024, 12:57=E2=80=AFPM Colin Percival = <cperciva@tarsnap.com <mailto:cperciva@tarsnap.com>> wrote: >>>>> On 4/19/24 16:11, Warner Losh wrote: >>>>> > add dtb support for RPI CM4, CM4s, CM4_ioBoard >>>>> > >>>>> > Signed-off-by: Klaus K=C3=BCchemann = <maciphone2@googlemail.com >>>>> <mailto:maciphone2@googlemail.com>> >>>>> > Reviewed by: imp >>>>> > Pull Request: = https://github.com/freebsd/freebsd-src/pull/1182 >>>>> <https://github.com/freebsd/freebsd-src/pull/1182>; >>>>> > --- >>>>> > --- a/release/arm64/RPI.conf >>>>> > +++ b/release/arm64/RPI.conf >>>>> > -DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb >>>>> bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb" >>>>> > +DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb >>>>> bcm2710-rpi-cm3.dtb \ >>>>> > + bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb = bcm2711-rpi-cm4.dtb >>>>> bcm2711-rpi-cm4s.dtb" >>>>>=20 >>>>> This broke the RPI release build, since bcm2711-rpi-cm4s.dtb = doesn't exist. >>>>> Is it provided by a port which we should add to the RPI build? >>>>>=20 >>>>> I thought it was in tree. I'll look into this and report back. >>>> Entirely possible. The release-building code is trying to copy it = from >>>> /usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb >>>> so if it's somewhere else we need to adjust that code. >>>=20 >>> The rpi-firmware port is supposed to provide all .dtb used here, but = we've never installed that one. It really shouldn't have been included = in the list to begin with, but I guess if there's demand we should fix = the port to include it. >>>=20 >>> Thanks, >>>=20 >>> Kyle Evans >> we only have tested/fixed the CM4-model, not forceably need the = cm4s.dtb , so no objections to remove cm4s.dtb from the dtb-list at = least temporarily. >> But please hold cm4.dtb and the cm4_io_.dtb, which will then = hopefully not break the rpi-release anymore. >=20 > I'm going to go ahead and remove just the rpi-cm4s.dtb, feel free to = update the port (sysutils/rpi-firmware) to grab it then try again once = new packages are available with it so that we don't break the snapshot = again from the same file. >=20 > Thanks, >=20 > Kyle Evans Yes, better at the moment , because Updating the port would require to test every rpi-model again because = the provided dtb-files can sometimes be very =E2=80=9Esensitive=E2=80=9C or critical in = behavior .=20 thank you and sorry for the breakage. Klaus --Apple-Mail=_1E6194A7-523A-4EAA-80C9-840CB6271984 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"content-type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;"><br = id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote = type=3D"cite"><div>Am 26.04.2024 um 00:09 schrieb Kyle Evans = <kevans@FreeBSD.org>:</div><br = class=3D"Apple-interchange-newline"><div><meta charset=3D"UTF-8"><span = style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none; float: none; = display: inline !important;">On 4/25/24 16:44, Klaus K=C3=BCchemann = wrote:</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant-caps: = normal; font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none;"><blockquote type=3D"cite" style=3D"font-family: Helvetica; = font-size: 12px; font-style: normal; font-variant-caps: normal; = font-weight: 400; letter-spacing: normal; orphans: auto; text-align: = start; text-indent: 0px; text-transform: none; white-space: normal; = widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;"><blockquote type=3D"cite">Am 25.04.2024 um 22:01 = schrieb Kyle Evans <kevans@FreeBSD.org>:<br><br>On 4/25/24 14:43, = Colin Percival wrote:<br><blockquote type=3D"cite">On 4/25/24 12:24, = Warner Losh wrote:<br><blockquote type=3D"cite">On Thu, Apr 25, 2024, = 12:57=E2=80=AFPM Colin Percival <cperciva@tarsnap.com = <mailto:cperciva@tarsnap.com>> = wrote:<br> <span = class=3D"Apple-converted-space"> </span>On 4/19/24 16:11, Warner = Losh wrote:<br> <span = class=3D"Apple-converted-space"> </span>> = add dtb support for RPI CM4, CM4s, = CM4_ioBoard<br> <span = class=3D"Apple-converted-space"> </span>><br> &nb= sp;<span class=3D"Apple-converted-space"> </span>> = Signed-off-by: Klaus K=C3=BCchemann = <maciphone2@googlemail.com<br> <span = class=3D"Apple-converted-space"> </span><mailto:maciphone2@googlem= ail.com>><br> <span = class=3D"Apple-converted-space"> </span>> = Reviewed by: imp<br> <span = class=3D"Apple-converted-space"> </span>> = Pull Request: = https://github.com/freebsd/freebsd-src/pull/1182<br> <spa= n = class=3D"Apple-converted-space"> </span><https://github.com/freebs= d/freebsd-src/pull/1182><br> <span = class=3D"Apple-converted-space"> </span>> = ---<br> <span = class=3D"Apple-converted-space"> </span>> --- = a/release/arm64/RPI.conf<br> <span = class=3D"Apple-converted-space"> </span>> +++ = b/release/arm64/RPI.conf<br> <span = class=3D"Apple-converted-space"> </span>> = -DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb<br> <span = class=3D"Apple-converted-space"> </span>bcm2710-rpi-cm3.dtb = bcm2711-rpi-4-b.dtb"<br> <span = class=3D"Apple-converted-space"> </span>> = +DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb<br> <span = class=3D"Apple-converted-space"> </span>bcm2710-rpi-cm3.dtb = \<br> <span = class=3D"Apple-converted-space"> </span>> + = bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb = bcm2711-rpi-cm4.dtb<br> <span = class=3D"Apple-converted-space"> </span>bcm2711-rpi-cm4s.dtb"<br><br>= <span class=3D"Apple-converted-space"> </span>This = broke the RPI release build, since bcm2711-rpi-cm4s.dtb doesn't = exist.<br> <span = class=3D"Apple-converted-space"> </span>Is it provided by a port = which we should add to the RPI build?<br><br>I thought it was in tree. = I'll look into this and report back.<br></blockquote>Entirely = possible. The release-building code is trying to copy it = from<br>/usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb<br>so if it's = somewhere else we need to adjust that code.<br></blockquote><br>The = rpi-firmware port is supposed to provide all .dtb used here, but we've = never installed that one. It really shouldn't have been included = in the list to begin with, but I guess if there's demand we should fix = the port to include it.<br><br>Thanks,<br><br>Kyle = Evans<br></blockquote>we only have tested/fixed the CM4-model, not = forceably need the cm4s.dtb , so no objections to remove cm4s.dtb from = the dtb-list at least temporarily.<br>But please hold cm4.dtb and the = cm4_io_.dtb, which will then hopefully not break the rpi-release = anymore.<br></blockquote><br style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;"><span style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;">I'm = going to go ahead and remove just the rpi-cm4s.dtb, feel free to update = the port (sysutils/rpi-firmware) to grab it then try again once new = packages are available with it so that we don't break the snapshot again = from the same file.</span><br style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;"><br style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;"><span style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline = !important;">Thanks,</span><br style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;"><br style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;"><span style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;">Kyle = Evans</span></div></blockquote><br></div><div>Yes, better at the moment = , because</div><div>Updating the port would require to test every = rpi-model again because the provided dtb-files</div><div> can = sometimes be very =E2=80=9Esensitive=E2=80=9C or critical in behavior = . </div><div><br></div><div> thank you and sorry for the = breakage.</div><div>Klaus</div><br></body></html>= --Apple-Mail=_1E6194A7-523A-4EAA-80C9-840CB6271984--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F4317843-3597-4675-A576-664955166762>