Date: 23 Sep 1998 21:20:15 +0200 From: dag-erli@ifi.uio.no (Dag-Erling C. =?iso-8859-1?Q?Sm=F8rgrav?= ) To: Studded <Studded@dal.net> Cc: Drew Derbyshire <ahd@kew.com>, freebsd-bugs@FreeBSD.ORG, freebsd-gnats-submit@FreeBSD.ORG Subject: Re: conf/8031: /etc/rc looks for /etc/sendmail.cf at startup Message-ID: <xzpvhmed4b4.fsf@hrotti.ifi.uio.no> In-Reply-To: Studded's message of "Wed, 23 Sep 1998 10:58:45 -0700" References: <199809231210.FAA18954@freefall.freebsd.org> <360936D5.9DAE1280@dal.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Studded <Studded@dal.net> writes:
> This isn't directed towards Drew, but technically the RHS of the test
> should be "XYES" instead of how it is now. The '=' conditional compares
> strings, so the LHS is correct, and it should be the same on both sides.
> [...]
> > ! if [ "X${sendmail_enable}" = X"YES" ]; then
> > echo -n ' sendmail'; /usr/sbin/sendmail ${sendmail_flags}
> > fi
The X is totally unnecessary as long as you have quotes around the
variable to make sure you get an empty string (rather than a missing
argument) if it's undefined or empty.
[ "${sendmail_enable}" = YES ] &&
echo -n ' sendmail' && /usr/sbin/sendmail ${sendmail_flags}
Might as well throw in a ${sendmail_program} for good measure:
[ "${sendmail_enable}" = YES ] &&
echo -n ' sendmail' && ${sendmail_program} ${sendmail_flags}
I prefer to place the echo command last so that ' sendmail' is not
printed unless sendmail started successfully.
DES
--
Dag-Erling Smørgrav - dag-erli@ifi.uio.no
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpvhmed4b4.fsf>