Date: Sun, 23 Apr 2006 16:13:39 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/cenon Makefile Message-ID: <20060423201339.GA74819@xor.obsecurity.org> In-Reply-To: <200604231522.k3NFMROj073587@repoman.freebsd.org> References: <200604231522.k3NFMROj073587@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Apr 23, 2006 at 03:22:27PM +0000, Dirk Meyer wrote: > dinoex 2006-04-23 15:22:27 UTC > > FreeBSD ports repository > > Modified files: > graphics/cenon Makefile > Log: > - fix broken > only problems with gcc4.x.x > > Revision Changes Path > 1.5 +4 -2 ports/graphics/cenon/Makefile > http://cvsweb.FreeBSD.org/ports/graphics/cenon/Makefile.diff?r1=1.4&r2=1.5 > | =================================================================== > | RCS file: /usr/local/www/cvsroot/FreeBSD/ports/graphics/cenon/Makefile,v > | retrieving revision 1.4 > | retrieving revision 1.5 > | diff -u -p -r1.4 -r1.5 > | --- ports/graphics/cenon/Makefile 2006/04/22 22:10:17 1.4 > | +++ ports/graphics/cenon/Makefile 2006/04/23 15:22:27 1.5 > | @@ -2,7 +2,7 @@ > | # Date created: 16 Nov 2005 > | # Whom: Alexey Dokuchaev <danfe@FreeBSD.org> > | # > | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/graphics/cenon/Makefile,v 1.4 2006/04/22 22:10:17 kris Exp $ > | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/graphics/cenon/Makefile,v 1.5 2006/04/23 15:22:27 dinoex Exp $ > | # > | > | PORTNAME= cenon > | @@ -17,8 +17,6 @@ EXTRACT_ONLY= ${DISTNAME}${EXTRACT_SUFX} > | MAINTAINER= danfe@FreeBSD.org > | COMMENT= A vector graphics tool for GNUstep > | > | -BROKEN= Does not compile > | - > | GNUSTEP_PREFIX?= ${LOCALBASE}/GNUstep > | PREFIX= ${GNUSTEP_PREFIX} > | NO_MTREE= yes > | @@ -36,6 +34,10 @@ MAKEFILE= GNUmakefile > | OPTIONS= FULL_LIBRARY "Install complete Cenon Library" off > | > | .include <bsd.port.pre.mk> > | + > | +.if ${CC} == "gcc40" || ${CC} == "gcc41" || ${CC} == "gcc42" > | +BROKEN= Does not compile > | +.endif It's wrong to test for CC this way - for example, what if the user has set CC=/usr/local/bin/gcc42? Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFES9/zWry0BWjoQKURAk3cAKDrp5ELqD3PX42HNwI9SgKvbeyivACfX83H NCDHIxztHw/72/O6+rvAqW4= =1qxG -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060423201339.GA74819>