Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Jun 2026 19:53:56 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 296246] stand: loader.efi slightly garbled menu with UEFI GOP
Message-ID:  <bug-296246-227-ILmCnPdnEt@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-296246-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296246

--- Comment #10 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=76aa776b5f47ecd0d45336e22795fef98af57d2f

commit 76aa776b5f47ecd0d45336e22795fef98af57d2f
Author:     ShengYi Hung <aokblast@FreeBSD.org>
AuthorDate: 2026-06-24 14:31:03 +0000
Commit:     ShengYi Hung <aokblast@FreeBSD.org>
CommitDate: 2026-06-30 19:52:55 +0000

    stand: Fix shadow buffer offset handling

    The shadow buffer is addressed relative to `tg_origin`, which includes
    the padding offset, whereas `gfxfb_blt` operates on coordinates without
    that offset. To make `gfx_fb_copy_area` emulate the behavior of
    `gfxfb_blt`, the source coordinates must include the padding offset,
    while the destination coordinates must not. The original implementation
    omitted the offset from the source coordinates; this change corrects
    that.

    Additionally, `gfx_fb_cons_display` already applies the padding offset,
    so the redundant adjustment is removed.

    PR:             296246
    Reported by:    2khramtsov@gmail.com
    Reviewed by:    imp
    Tested by:      2khramtsov@gmail.com, junchoon@dec.sakura.ne.jp,
    naito.yuichiro_@gmail.com
    Fixes:          32da2f23ae4d
    MFC after:      2 weeks
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D57821

 stand/common/gfx_fb.c | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-296246-227-ILmCnPdnEt>